[Bug 9769] New: Replace YUI buttons on acquisitions basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Bug ID: 9769 Summary: Replace YUI buttons on acquisitions basket page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/basket.pl?basketno= OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the acquisitions basket page are constructed using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace YUI buttons on |Replace YUI buttons on |acquisitions basket page |acquisitions basket page | |with Bootstrap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15976&action=edit Bug 9769 - Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9779 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I cannot reopen a closed basket. All the rest is correct. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15976|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16240&action=edit Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16269&action=edit Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. Signed-off-by: Brendan <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Followed test plan and this worked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16269|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16573&action=edit [PASSED QA] Bug 9769 [Revised] Replace YUI buttons on acquisitions basket page with Bootstrap Toolbar buttons on the acquisitions basket page are constructed by YUI. They should use Bootstrap instead. Other minor changes: Fixes for invalid markup. To test, view baskets in various states: Empty, open closed. View baskets in groups and not in groups. Buttons should look correct and work correctly: - Edit - Delete - Close - Reopen - Export Revision corrects check for 'skip_confirm_reopen' variable when reopening baskets. Please test with BasketConfirmations both on and off. Signed-off-by: Brendan <brendan@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested all options, some notes about behaviour: - closing a basket is only possible, when there are no uncertain prices (no button close basket) - reopening a basket requires, that you first remove the basket from any basket group (no button to reopen basket) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18068&action=edit [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All test passed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18068|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard@gmail.com> --- Comment on attachment 18068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18068 [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR wrong bug -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org