[Bug 27992] New: when recording local use with STAT patron items are not checked in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Bug ID: 27992 Summary: when recording local use with STAT patron items are not checked in Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When recording local use using a statistical patron, the Lost status updates, but if an item is checked out, it does not get checked in. To replicate: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared In this situation, the item should be checked in/available status updated when it is "checked out" to the statistical patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Donna, can you explain the use case here a bit? Why is the item checked out at the time of local use? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #2 from Donna <bwsdonna@gmail.com> --- Typically, the items are not going to be checked out, however, items that are checked out sometimes make their way back to the shelf without being checked in. Just like with inventory, when an item is scanned in this scenario, the status should be updated/checked in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|when recording local use |When recording local use |with STAT patron items are |with statistical patron |not checked in |items are not checked in --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Donna from comment #2)
Typically, the items are not going to be checked out, however, items that are checked out sometimes make their way back to the shelf without being checked in. Just like with inventory, when an item is scanned in this scenario, the status should be updated/checked in.
Thx, I agree that it should be checked in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1 on this. A local use scan assumes the item is in the library and therefore any current checkout on it should be ended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 126865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126865&action=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. 8. Item is checked in and now seen as available -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com Version|20.05 |master Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #6 from Donna <bwsdonna@gmail.com> --- Works as expected! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126865|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127189&action=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. 8. Item is checked in and now seen as available Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as described, no obvious regressions and the QA scripts are happy. I'm not sure how any outstanding fines, lost item charges should be handled in this case.. but I feel that could be handled as a follow-up bug if we discover a need. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128633&action=edit Bug 27992: Unit test Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127189|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128634&action=edit Bug 27992: Call AddReturn if borrower is statistical patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. 8. Item is checked in and now seen as available Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works as intended as far as I can tell, but I have something to clarify: In marked my item lost using the 'claims returned' feature. With this change the item will be returned and the claim remains unresolved. Is this an issue? When you try to return an item that is lost with BlockReturnOfLostItems we deny the return. But we allow checking it out to a statistical patron. Should the latter also be blocked? Maybe instead of resolving the lost status automatically, we should ask for confirmation and when BlockReturnOfLostItems is set even block it hard. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to master, I'll rebase and return to this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128634|0 |1 is obsolete| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146041&action=edit Bug 27992: Call AddReturn when checking in localuse item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> ---
In marked my item lost using the 'claims returned' feature. With this change the item will be returned and the claim remains unresolved. Is this an issue?
In this case should we return the item and resolve the claim. Or block the return and leave the claim?
When you try to return an item that is lost with BlockReturnOfLostItems we deny the return. But we allow checking it out to a statistical patron. Should the latter also be blocked?
If the item is LOST and BlockReturnOfLostItems is off, ask for confirmation but if the item is LOST and BlockReturnOfLostItems is on block the return? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #16 from Donna <bwsdonna@gmail.com> --- (In reply to Lucas Gass from comment #15)
In marked my item lost using the 'claims returned' feature. With this change the item will be returned and the claim remains unresolved. Is this an issue?
In this case should we return the item and resolve the claim. Or block the return and leave the claim?
Ideally, have it behave the same way as when I check in anything else that has a claim on it - check it in, and give a modal that allows for resolving
When you try to return an item that is lost with BlockReturnOfLostItems we deny the return. But we allow checking it out to a statistical patron. Should the latter also be blocked?
If the item is LOST and BlockReturnOfLostItems is off, ask for confirmation but if the item is LOST and BlockReturnOfLostItems is on block the return?
Yes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #17 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- Oooh! We were just talking about the need for this today! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #18 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- It sounds like the plan to (1) respect BlockReturnOfLostItems, (2) ask for confirmation when recording local use on a lost item if it is not blocked, and (3) resolve any return claims on the item, addresses all the concerns that have been raised. For #2, I feel like it could also make sense to follow the setting for IssueLostItem instead of requiring confirmation no matter what, but I'm not sure I have strong reasons for insisting on it if there are objections/downsides. Anything else that needs to be resolved before we can move forward with this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- I thin(In reply to Emily Lamancusa from comment #18)
It sounds like the plan to (1) respect BlockReturnOfLostItems, Yes.
(2) ask for confirmation when recording local use on a lost item if it is not blocked, and (3) resolve any return claims on the item, addresses all the concerns that have been raised. I think this should have the same behavior as when checking in a lost item.
For #2, I feel like it could also make sense to follow the setting for IssueLostItem instead of requiring confirmation no matter what, but I'm not sure I have strong reasons for insisting on it if there are objections/downsides. In my opinion this should be handled in a separate bug.
I think we can now move this from 'In discussion' to FQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- I'm finding plenty of other issues here that I think might need to be addressed when checking out to a statistical patron: 1. If there is a hold on the item that is checked in to a stats patron no indication that there is a hold is give/ 2. BlockReturnOfWithdrawnItems is not honored. 3. AllowReturnToBranch is not checked, if I check an item in with the statistical patron while logged in at a different library AllowReturnToBranch is not honored. 4. Recalls, if there is a recall on the item that is checked out to the statistical patron no warning is given. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #21 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Ooh, good point. I was thinking that AddReturn had all of that covered, but the last time I looked at this I missed the fact that AddReturn would only get called if the item had a current checkout. Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146041|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158011&action=edit Bug 27992: Call AddReturn on stats patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158011|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158073&action=edit Bug 27992: Call AddReturn on stats patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared. 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. Item is checked in. 8. Set BlockReturnOfLostItems to Block. 9. Have a checkout to another patron then mark it as lost. 10. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 12. Conform the item remains on the patron's account. 13. Turn off BlockReturnOfLostItems, check out the same item to the Statistical Patron. You should see a message "Item was lost, now found." 14. Conform the item was actually checked in. 15. Set BlockReturnOfWithdrawnItems to Block. 16. Have a checkout to another patron then mark it as withdrawn. 17. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 18. Conform the item remains on the patron's account. 19. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 20. Conform the item was actually checked in. 21. Have an item on a regular patron account that has a hold on it. 22. Check it out to the Statistical Patron 23. See the message "Item on hold, please checkin." 24. Have an item on a regular patron account that has a claim return on it. 25. Checkit it out to the Statistical Patron. 26. See the message "Item claimed returned, please checkin." 27. Have an item on a regular patron account that has been recalled. 28. Checkit it out to the Statistical Patron. 29. See the message "Item can fill a recall, please checkin." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128633|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158086&action=edit Bug 27992: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158073|0 |1 is obsolete| | --- Comment #25 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 158216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158216&action=edit Bug 27992: Call AddReturn on stats patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared. 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. Item is checked in. 8. Set BlockReturnOfLostItems to Block. 9. Have a checkout to another patron then mark it as lost. 10. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 12. Conform the item remains on the patron's account. 13. Turn off BlockReturnOfLostItems, check out the same item to the Statistical Patron. You should see a message "Item was lost, now found." 14. Conform the item was actually checked in. 15. Set BlockReturnOfWithdrawnItems to Block. 16. Have a checkout to another patron then mark it as withdrawn. 17. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 18. Conform the item remains on the patron's account. 19. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 20. Conform the item was actually checked in. 21. Have an item on a regular patron account that has a hold on it. 22. Check it out to the Statistical Patron 23. See the message "Item on hold, please checkin." 24. Have an item on a regular patron account that has a claim return on it. 25. Checkit it out to the Statistical Patron. 26. See the message "Item claimed returned, please checkin." 27. Have an item on a regular patron account that has been recalled. 28. Checkit it out to the Statistical Patron. 29. See the message "Item can fill a recall, please checkin." Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158086|0 |1 is obsolete| | --- Comment #26 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 158217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158217&action=edit Bug 27992: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Looks great and works as intended! One small, quality-of-life thing (not a blocker): When it returns a checked-out item, could the return message link directly to the patron account? The checkout table does this, so it would be nice if the return message here did the same. Testing notes: 0. Create a statistical patron category 0.5 Set sysprefs and circulation rules: - MarkLostItemsAsReturned to never return items when marked as lost - ClaimsReturnedLostValue - UseRecalls to Use - Create/edit a circulation rule to allow at least 1 recall I also confirmed that if a lost item with an associated fine is checked in, it respects the circulation rules for refunding fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Perltidied in a follow-up to make the tests pass. Please remember to run QA test tools and perltidy your code. 2) Ternary operator needed? + my $block_lost_return = C4::Context->preference("BlockReturnOfLostItems") ? 1 : 0; Do we really need the ternary operator here? The preference is already stored with 0 and 1 in the database. 3) I feel like the information to the users could be a bit more prominent, maybe something for another bug. Not a blocker here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158216|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158462&action=edit Bug 27992: Call AddReturn on stats patron To test: 1. Create a Statistical Patron 2. Check out an item to the Stat Patron, that is checked out to another user 3. See that the local use is recorded, but the item does not get checked in 4. Check out an item that has a lost status and note that the local use is recorded, and the lost status is cleared. 5. Item is NOT checked in 6. Apply patch 7. Repeat steps 2 - 4. Item is checked in. 8. Set BlockReturnOfLostItems to Block. 9. Have a checkout to another patron then mark it as lost. 10. Check it out to the Statistical Patron. You should see the message "Item was lost, cannot be returned." 12. Conform the item remains on the patron's account. 13. Turn off BlockReturnOfLostItems, check out the same item to the Statistical Patron. You should see a message "Item was lost, now found." 14. Conform the item was actually checked in. 15. Set BlockReturnOfWithdrawnItems to Block. 16. Have a checkout to another patron then mark it as withdrawn. 17. Check it out to the Statistical Patron. You should see the message "Item was withdrawn, cannot be returned." 18. Conform the item remains on the patron's account. 19. Turn off BlockReturnOfWithdrawnItems, check out the same item to the Statistical Patron. You should see a message "Item was withdrawn." 20. Conform the item was actually checked in. 21. Have an item on a regular patron account that has a hold on it. 22. Check it out to the Statistical Patron 23. See the message "Item on hold, please checkin." 24. Have an item on a regular patron account that has a claim return on it. 25. Checkit it out to the Statistical Patron. 26. See the message "Item claimed returned, please checkin." 27. Have an item on a regular patron account that has been recalled. 28. Checkit it out to the Statistical Patron. 29. See the message "Item can fill a recall, please checkin." Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158217|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158463&action=edit Bug 27992: Unit test Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158464&action=edit Bug 27992: (QA follow-up) Perltidy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158465&action=edit Bug 27992: (QA follow-up) Terminology: returned -> checked in Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #35 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 158900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158900&action=edit Bug 27992: [23.05] (follow-up) Fix unit test with unblessed patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- Fixed test suite, AddIssue still uses unblessed patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |pedro.amorim@ptfs-europe.co | |m Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35751 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35751 [Bug 35751] When recording local use with a statistical patron, alert of active transfers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- In hindsight it seems very strange to me to put an AddReturn in a sub that you should use to just know if a book can be issued? See discussion too on bug 35840. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #37)
In hindsight it seems very strange to me to put an AddReturn in a sub that you should use to just know if a book can be issued? See discussion too on bug 35840.
That's really odd.. that should be an idempotent action surely!? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> ---
That's really odd.. that should be an idempotent action surely!?
I opened Bug 35950 to continue to discuss this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24035 [Bug 24035] When recording local use, holds should be captured -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37505 [Bug 37505] Statistical patrons don't display information about item status if item wasn't checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27992 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38990 [Bug 38990] Statistical patron checkouts don't display alert that LOST value has been cleared -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org