[Bug 18955] New: autocomplete is on in OPAC password recovery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Bug ID: 18955 Summary: autocomplete is on in OPAC password recovery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In OPAC password recovery form autocomplete is not disabled. So when login or email is entered, it is saved in browser input history for autocomplete. This is a major issue for OPAC on computers with public access. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16711 Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 65092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65092&action=edit Bug 18955 - autocomplete is on in OPAC password recovery In OPAC password recovery form autocomplete is not disabled. So when login or email is entered, it is saved in browser input history for autocomplete. This is a major issue for OPAC on computers with public access. This patch adds autocomplete off on forms. Test : - Enable system preferences OpacPasswordChange and OpacResetPassword - Go to OPAC - Be sure to not be logged in - Click on "Forgot your password?" - Enter a loggin and email and Submit => Without patch there is an autocompletion with values you entered => With patch there is no autocompletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65092|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 65138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65138&action=edit Bug 18955 - autocomplete is on in OPAC password recovery In OPAC password recovery form autocomplete is not disabled. So when login or email is entered, it is saved in browser input history for autocomplete. This is a major issue for OPAC on computers with public access. This patch adds autocomplete off on forms. Test : - Enable system preferences OpacPasswordChange and OpacResetPassword - Go to OPAC - Be sure to not be logged in - Click on "Forgot your password?" - Enter a loggin and email and Submit => Without patch there is an autocompletion with values you entered => With patch there is no autocompletion Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65138|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 65165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65165&action=edit Bug 18955 - autocomplete is on in OPAC password recovery In OPAC password recovery form autocomplete is not disabled. So when login or email is entered, it is saved in browser input history for autocomplete. This is a major issue for OPAC on computers with public access. This patch adds autocomplete off on forms. Test : - Enable system preferences OpacPasswordChange and OpacResetPassword - Go to OPAC - Be sure to not be logged in - Click on "Forgot your password?" - Enter a loggin and email and Submit => Without patch there is an autocompletion with values you entered => With patch there is no autocompletion Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18955 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|autocomplete is on in OPAC |Autocomplete is on in OPAC |password recovery |password recovery -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org