[Bug 32740] New: Add a new option patron home library to OverdueNoticeFrom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Bug ID: 32740 Summary: Add a new option patron home library to OverdueNoticeFrom Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: hammat.wele@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This patch will add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 145779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145779&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1@test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17649 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- This works as described, glad to see this patch as this is the behavior some libraries would like to see. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145779|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149695&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1@test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Hinemoea Viault <hinemoea.viault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149695|0 |1 is obsolete| | --- Comment #4 from Hinemoea Viault <hinemoea.viault@inlibro.com> --- Created attachment 150806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150806&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1@test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150806|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 155541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155541&action=edit Bug 32740: Add a new option patron home library to OverdueNoticeFrom This patch add 'patron home library' option to the OverdueNoticeFrom preference. When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library To Test 1. Create 3 libraries B1, B2 and B3 1.1. Go to Koha administration, click on Libraries 1.2. Click New library 1.3. Fill the Library Code (ex. B1), Name(ex. B1) and email(ex. b1@test.com) fields. 2. Create a user belonging to B1 2.1. Go to patron module, click on New patron and patron 2.2. Fill the Surname,Card number,Primary email,Card number field and select B1 as Library. 3. Create 2 notices : the first belongs to B2 and the second belong to B3 3.1. Go to Cataloging module and click on new 3.2. field the required field (000 subfield 0, 003 subfield 0, 005 subfield 0, 008 subfield 0, 040 subfield c,245 subfield a, and 942 subfield c ) 3.3. Click on save 3.4. In the item form, Select Home library = B2 and Current library = B2 and type a Barcode. 3.5. Repeat 3.1 3.2 3.3 3.4 to create a second notice belong to B3 4. Have (or create) a default notice for all branches in Notices and Slips Module 5. Make sure you connected to branch B2 or Switch to branch B2 6. checkout item I2 (belonging to B2) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 7. switch to branch B3 8. checkout item I3 (belonging to B3) to the user created in step 2 (specifying as due date the day before (1 day overdue)) 9. make sure you have defined 'Overdue notice/status triggers' for that patron category, ie with Delay=1 so that 'Overdue Notice' is selected and 'Email' is checked. Note: we have a user belong to B1, two item: I2 belong to B2, I3 belong to B3 and the user has borrowed I2 from B2 and I3 from B3. 10. Test 10.1. Search for OverdueNoticeFrom in System preferences and select item home library 10.2. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => Two new entries will be generated in message_queue DB table, coming from different branches that have the SAME list of overdue items. => The sender address is the item home library address for each entry. 11. Apply the patch 12. Search for OverdueNoticeFrom in System preferences => There is now 'patron home library' in the options list 13. Select patron home library 14. from cli run 'perl ./misc/cronjobs/overdue_notices.pl' => You will see that only one message had been created. Its content shows both B2 and B3 overdue items => The sender address matches B1 address (the patron home library). 15. Search for OverdueNoticeFrom in System preferences and select cron 16. from cli run './misc/cronjobs/overdue_notices.pl --frombranch patron-homebranch' => you will get the same result at step 14 Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Hinemoea Viault <hinemoea.viault@inlibro.com> Was failing the qa script, so I perltidied the changed lines. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 --- Comment #8 from Ray Delahunty <r.delahunty@arts.ac.uk> --- Is any of the code that has fixed this bug transferrable to resolve bug 34140? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/817 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32740 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41315 [Bug 41315] Using patron-homelibrary option for overdue notices may not send notices to all branches -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org