[Bug 10706] New: keyword search on reports should search report number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Bug ID: 10706 Summary: keyword search on reports should search report number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org When using the keyword filter on the reports page it should also let you search the report number - or there should be a report number filter, but I think expanding the keyword is probably easier. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37969&action=edit Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37969|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37988&action=edit Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38008&action=edit Bug 10706: Add test I found this test this morning in my working directory, could be useful here :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|normal |enhancement QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, unfunnily... this test seems to delete any existing reports in your database (which is why it failed for me the first time and passed the second time I ran it... ) Could you please fix that even if it's a bit scope creeping? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I apologize to the test. It's innocent. But: somehow I manage to make all my reports disappear. Can someone try and confirm? 1) Search for an existing keyword or number = results are ok 2) Search for a non-existing keyword or number = 'no results found' - ok 3) Now click 'used saved' - no reports are showing up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
I apologize to the test. It's innocent.
But: somehow I manage to make all my reports disappear. Can someone try and confirm?
1) Search for an existing keyword or number = results are ok 2) Search for a non-existing keyword or number = 'no results found' - ok 3) Now click 'used saved' - no reports are showing up
Confirmed, but not related to this patch (come from commit 8360343fbc1fb4d8806db951aea8b04ad99d00c1 Date: Wed Apr 6 14:56:45 2011 +1200 Bug 6033 : wr77488 : report selection filter Please open a new bug report. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38046&action=edit Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37988|0 |1 is obsolete| | Attachment #38008|0 |1 is obsolete| | Attachment #38046|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38048&action=edit [PASSED QA] Bug 10706: Search reports by id This patch adds the ability to search reports by their id. Test plan: 1/ Go on the saved report list (reports/guided_reports.pl?phase=Use saved) 2/ Search for a report id (refer to the ID column in the table) 3/ The result should be consistent That the filters are not kept, already existed. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I filed a new bug report bug 14008 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38049&action=edit [PASSED QA] Bug 10706: Add test Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38051&action=edit [PASSED QA] Bug 10706: Delete saved_reports to be sure no reports existed We need to be sure no report existed before launching the tests. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14008 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10706 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org