http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36095&action=edit Bug 13739 - KohaDates should display hours if they exists by default unless specified There are many parts of Koha that are now hiding hours by default. This is rarely helpful. KohaDates should display hours by default unless the time is 23:59, in which case the hours should be not be displayed. Test Plan: 1) Check out two items, one due at at an hour, one not 2) View the patron's circ history, note you don't see the hours 3) Apply this patch 4) View the circ history again, note the hours are listed for date/time where the time is not 23:59. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #3 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 36322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36322&action=edit [SIGNED OFF] Bug 13739 - KohaDates should display hours if they exists by default unless specified There are many parts of Koha that are now hiding hours by default. This is rarely helpful. KohaDates should display hours by default unless the time is 23:59, in which case the hours should be not be displayed. Test Plan: 1) Check out two items, one due at at an hour, one not 2) View the patron's circ history, note you don't see the hours 3) Apply this patch 4) View the circ history again, note the hours are listed for date/time where the time is not 23:59. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Before this patch, the plugin manages the as_due_date parameter. It's not with your patch. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13739 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Before your patch, [% my_date | $KohaDates as_due_date => 1 %] worked to display a date as a due date. After your patch, this parameter is not checked to display the date as requested. And you should also have a look at t/db_dependent/Koha_template_plugin_KohaDates.t, the tests don't pass with your patch. -- You are receiving this mail because: You are watching all bug changes.