[Bug 15910] New: Move header search keep text JavaScript into staff-global.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Bug ID: 15910 Summary: Move header search keep text JavaScript into staff-global.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48364&action=edit Bug 15910 - Move header search keep text JavaScript into staff-global.js Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js. This patch does so. To test, apply the patch and clear your browser cache if necessary. - Navigate to any page in the staff client which has multiple header search tabs. - Type something in one of the tabs. - Switch tabs. Verify that your text was copied to the newly-displayed form field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48364|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 48373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48373&action=edit Bug 15910 - Move header search keep text JavaScript into staff-global.js Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js. This patch does so. To test, apply the patch and clear your browser cache if necessary. - Navigate to any page in the staff client which has multiple header search tabs. - Type something in one of the tabs. - Switch tabs. Verify that your text was copied to the newly-displayed form field. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48373|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48474&action=edit Bug 15910 - Move header search keep text JavaScript into staff-global.js Bug 14189 added some global JavaScript to a new include file which is included in doc-head-close.inc. Since it's included globally, there is no reason not to move it to staff-global.js. This patch does so. To test, apply the patch and clear your browser cache if necessary. - Navigate to any page in the staff client which has multiple header search tabs. - Type something in one of the tabs. - Switch tabs. Verify that your text was copied to the newly-displayed form field. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15910 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org