[Bug 41142] New: Update jQuery-validate plugin to 1.21.0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Bug ID: 41142 Summary: Update jQuery-validate plugin to 1.21.0 Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org A new bug report for version 1.21.0.
We've gotten reports that the jQuery-validate plugin is flagging in vulnerability scans (https://nvd.nist.gov/vuln/detail/CVE-2022-31147 for details on the associated CVE).
I've put this in security to be on the safe side but if it should be moved, please do.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188644&action=edit Bug 41142: Update jQuery-validate plugin to 1.21.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.21.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evelyn@bywatersolutions.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 34623 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 cking@uttyler.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cking@uttyler.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188644|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190316&action=edit Bug 41142: Update jQuery-validate plugin to 1.21.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.21.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <you@example.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I have signed off, but did note this behavour for the new budget form - which is the same before and after the patch: 1. New budget form: - if I enter in start date but nowhere else, I can't save and it stays on the form - if I enter in the end date but nowhere else, I can't save and it stays on the form - if I enter in the start date and end date but nothing in description, I can't save and it stays on the form - for each of the above, only the description field comes up with "This field is required" - if I just enter something in the description (which is required), but not in start date and end date, and click Save, I can, but it is not saved and you go back to the budget listing page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190316|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 190319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190319&action=edit Bug 41142: Update jQuery-validate plugin to 1.21.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.21.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #6 from David Nind <david@davidnind.com> --- My sign-off line was incorrect, so have updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Athens County Public list of Sponsors| |Libraries Status|Signed Off |Passed QA Sponsorship status|--- |Sponsored Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 190695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190695&action=edit Bug 41142: Update jQuery-validate plugin to 1.21.0 This patch updates the jQuery validation plugin in both the staff interface and the OPAC to the latest version, 1.21.0. To test, apply the patch and clear your browser cache if necessary. Test various pages in the staff client to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Perform the same check of the "Change password" form in the OPAC. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |Failed QA --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- [FAIL] koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.validate.min.js FAIL forbidden_patterns forbidden pattern: console.log (line 5) FAIL new_line_at_the_end_of_file Missing new line at the end of file, make sure your editor correctly reads .editorconfig ('insert_final_newline = true'). See bug 40541. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass (lukeg) from comment #8)
[FAIL] koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.validate.min.js
Correcting these items would be editing the code of a third-party library which we don't usually do. My opinion is that we ignore these failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #9)
(In reply to Lucas Gass (lukeg) from comment #8)
[FAIL] koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.validate.min.js
Correcting these items would be editing the code of a third-party library which we don't usually do. My opinion is that we ignore these failures.
Makes sense, ignoring. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to main for 26.05.00. Nice work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.02 |26.05.00,25.11.02,25.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Correction: This was pushed to 25.05.x based on 25.05.08 (not 25.05.07 as previously noted). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|26.05.00,25.11.02,25.05.09 |26.05.00,25.11.02,25.05.09, released in| |24.11.14 --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.14 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41142 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- No change to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org