[Bug 30380] New: No suggestions ASKED letter transported by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 Bug ID: 30380 Summary: No suggestions ASKED letter transported by email Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org C4/Suggestions line 487 calls GetPreparedLetter with status==ASKED in the letter code parameter, causing warning at line 583 in C4/Letters: No suggestions ASKED letter transported by email Since we have no ASKED notice, we should either check the status and not call Letters or add this notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- At the moment you "turn off" notices by deleting them if you don't want to send a notice for all status changes. If we edit that type of code it might be nice to not create an error/warning if the notice is missing, but assume it's ok to not send an email then. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #1)
At the moment you "turn off" notices by deleting them if you don't want to send a notice for all status changes. If we edit that type of code it might be nice to not create an error/warning if the notice is missing, but assume it's ok to not send an email then.
I would not recommend to change Letters but Suggestions here. Instead of the approach I send the status and hope that there is a notice for it, make clear for which statuses you expect a notice when modifying suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, having a list of status where a notice can be sent makes sense instead of guessing. But I wonder if that was intentional to allow sending for notices for custom suggestion status? They are added using the SUGGEST_STATUS authorised value category. I just tried to make sure we take into account that a AVAILABLE notice might be deleted intentionally because the library doesn't want to send that kind of notice and it should not explode then :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30380 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39885 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org