https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I tried to look at the db data before and after the change, and I don't see a difference. I thought maybe it was NULL and after it was filled with the correct values, but the values are already there... Layout 17 before step 13 MariaDB [koha_kohadev]> select * from creator_layouts where layout_id = 17 \G; *************************** 1. row *************************** layout_id: 17 barcode_type: CODE39 start_label: 1 printing_type: BIBBAR layout_name: Label Test guidebox: 0 oblique_title: 1 font: TR font_size: 3 scale_width: 0.080000 scale_height: 0.010000 units: POINT callnum_split: 0 text_justify: L format_string: title, author, isbn, issn, itemtype, barcode, itemcallnumber layout_xml: <opt></opt> creator: Labels 1 row in set (0.001 sec) Layout 17 after step 14 MariaDB [koha_kohadev]> select * from creator_layouts where layout_id = 17 \G; *************************** 1. row *************************** layout_id: 17 barcode_type: CODE39 start_label: 1 printing_type: BIBBAR layout_name: Label Test guidebox: 0 oblique_title: 1 font: TR font_size: 3 scale_width: 0.800000 scale_height: 0.010000 units: POINT callnum_split: 0 text_justify: L format_string: title, author, isbn, issn, itemtype, barcode, itemcallnumber layout_xml: <opt></opt> creator: Labels 1 row in set (0.000 sec) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166443|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 166667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166667&action=edit Bug 36819: Default layout data prints squished barcodes This patch changes the default layout data for the barcode width. To test: **On a fresh db** 1. Go to Cataloging > Label creator 2. Click New > Label batch 3. Enter the following barcodes in the text field (or enter your own) 39999000010114 39999000010138 39999000010152 39999000011333 39999000002331 39999000002355 4. Click Add items 5. Click Export full batch 6. Choose the following - Template: Avery 5160 | 1 x 2-5/8 - Layout: Label test 7. Click Export 8. Click Download as PDF 9. Open the PDF --> Note the squished barcodes 10. Apply patch and reset_all 11. Redo steps 1 to 9 --> Note the barcodes now look OK Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166667|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166734&action=edit Bug 36819: Default layout data prints squished barcodes This patch changes the default layout data for the barcode width. To test: **On a fresh db** 1. Go to Cataloging > Label creator 2. Click New > Label batch 3. Enter the following barcodes in the text field (or enter your own) 39999000010114 39999000010138 39999000010152 39999000011333 39999000002331 39999000002355 4. Click Add items 5. Click Export full batch 6. Choose the following - Template: Avery 5160 | 1 x 2-5/8 - Layout: Label test 7. Click Export 8. Click Download as PDF 9. Open the PDF --> Note the squished barcodes 10. Apply patch and reset_all 11. Redo steps 1 to 9 --> Note the barcodes now look OK Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Did we figure out why this change became necessary? Should we have a note for existing installations or even a database update? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #7)

Did we figure out why this change became necessary? Should we have a note for existing installations or even a database update?

The existing updatedb was correct. It was only for new installations that there was a problem. Is there a way to discriminate the ones that are ok and the ones that were installed since the bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Katrin Fischer from comment #10)

Thx Caroline. I think maybe we can do without an additional update then as we can not really be sure if the value is 'original' or has been changed?

Can we do "IF value = 0.080000 THEN change value to 0.800000" ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #13 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Katrin Fischer from comment #12)

We can do something like:

UPDATE creator_layouts SET scale_width = 0.800000 WHERE scale_width = 0.080000;

We cannot really tell if it's an unchanged sample one... but maybe that's a very low risk here.

Just catching up here. This really should not have been pushed without the constraint Katrin proposes. the time we think it won't matter, it will. That's just how things roll unfortunately. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: Hi Chris N.! *waves* -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 166974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166974&action=edit Bug 36819: (follow-up) Updatedatabase to correct wrong value This patch adds an update to correct the value of scale_width to 0.800000 IF it is 0.080000. It should not change the value if it is anything else than 0.080000. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166983&action=edit Bug 36819: (QA follow-up) Improve update output -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, seeing this, I'll try to see if I can understand/fix: FAIL installer/data/mysql/atomicupdate/bug_36819.pl FAIL valid syntax error installer/data/mysql/atomicupdate/bug_36819.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yes, I did - it was a stray semicolon in the follow-up. Fixed and pushed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like 'additional_work_needed' is obsolete -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #27 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Fridolin Somers from comment #25)

Looks like 'additional_work_needed' is obsolete

I think so too. I don't see what else is missing. I removed the keyword. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the default release notes| |label layouts value for the | |barcode width (Cataloging > | |Tools > Label creator > | |Manage > Layouts > choose a | |layout). It was incorrectly | |set to 0.080000 when it | |should have been 0.800000 - | |this was resulting is | |squished barcodes when | |printing. | | | |Note: For | |existing 23.11 | |installations, this updates | |the correct value for the | |barcode width (field | |scale_width) to 0.800000 IF | |it is 0.080000. If it is | |any other value, no change | |is made. Status|Pushed to stable |Needs documenting --- Comment #29 from David Nind <david@davidnind.com> --- I've added a release note, even though it was pushed to 24.05. I've also changed the status to "Needs documenting", as this is a fix for an enhancement in 23.11.00 that was not back ported to any earlier releases. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #30 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36819 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #31 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This is a bug fix, no documentation needed. -- You are receiving this mail because: You are watching all bug changes.