https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #0)

For a long time I am copying koha-functions.sh to /usr/share/koha/bin, since that is the location that the koha-* scripts expect it to be.

Talking about a gitified dev package install. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 136580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136580&action=edit Bug 31055: Update install location for koha-functions Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Cook from comment #4)

Well, koha-functions.sh isn't a command/executable that should be in the $PATH, so really it shouldn't be in /usr/sbin (or /usr/share/koha/bin really).

koha-functions.sh should probably be in /usr/lib/koha or /usr/share/koha/lib I suppose.

Thx David. Yes, you are quite right about that. Pragmatically, I would not mind pushing it along with the real scripts though. And cheatingly we could add some kind of help/usage statement to it, making it a real script too :) The fact that we are storing it in debian/scripts, gave it the .sh extension and copy it to koha/bin does not help either.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813@mypacks.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 --- Comment #10 from wajasu <matted-34813@mypacks.net> --- if you colocate the koha-functions.sh next to the other scripts, you can source them path relative. But if other scripts somewhere else them, they will use have an absolute path. Some lib or scripts directory is definitely desired with an absolute path. Will they be used by maintenance scripts? That you probably don't want in /usr/sbin. I didn't find any currently when grepping. Most of our scripts are perl, but these are bash shell. A) /usr/share/koha/lib <-- perl code B) /usr/share/koha/lib/scripts <-- doesn't exist yet C) /usr/sbin <-- but gets out commands available in system dir D) /usr/share/koha/bin <-- This is where koha-functions.sh is now. (which not on the PATH in KTD. by design?) I can easily test many of the koha-functions by sourcing the file from debian/scripts and just calling them in the shell to examine $? and such. Then I just run the cp_debian_files.pl everytime I make change. Because the koha-commands are sourcing the absolute path anyway. A pain to fix/test, but it works. I tried to add a PREPATH inthe files/templates/defaults.env and change it in my .env, but alas run.sh is set in stone in the image. Making it less easy to change (accidentall). I was trying to put /kohadevbox/koha/debian/scripts prepended to the PATH so I could edit/test without cp_debian_files.pl but that would only work if run.sh had PATH=${PREPATH}:/usr/bin/usr/sbin/${PATH}:/kohadevbox/bin and the koha-* scripts used source ./koha-functions.sh Maybe making it less painful to test with koha_functions.sh in the same directory as /usr/sbin is less clunky to fix/test and even explain an easier test plan (without cp_debian_files.pl). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31055 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Closing this one (again) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.