[Bug 12927] New: Problems with item information tab on acq order from staged page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Bug ID: 12927 Summary: Problems with item information tab on acq order from staged page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: bgkriegel@gmail.com Moving this to a new bug report, hope the title makes sense :) To reproduce, go on acqui/addorderiso2709.pl?import_batch_id=3&basketno=7&booksellerid=5 (change ids), tab 'Item information'. You will get: b - Propriétaire HASH(0xd220cb0) Required c - Dépositaire HASH(0xd44a3ec) Required e - Localisation HASH(0xd44ab30) Required The dropdown list are replaced by the hashref address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12673 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I'l fix this ASAP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 31639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31639&action=edit Bug 12927: Problems with item information tab on acq order from staged page This patch fixes a regression introduced (by me) on Bug 12673. I adds the code needed to display properly all fields To test: 1) Check that 'AcqCreateItem' syspref is set to 'placing an order' 2) Satage a file with some items 3) Go to a Vendor, create a basket, clic add from staged file, select your file 4) On 'Item information' tab fields are displayed wrong 5) Apply the patch 6) Reload, display must now be fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31639|0 |1 is obsolete| | --- Comment #3 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31915&action=edit Bug 12927: Problems with item information tab on acq order from staged page I've applied the patch against master 3.17.00.025 The display of the 11 dropdown lists in the "Item information" tag: 0 - Withdrawn status 2 - Source of classification or shelving scheme 4 - Damaged status 5 - Use restrictions 7 - Not for loan 8 - Collection code a - Permanent location b - Current location c - Shelving location j - Shelving control number y - Koha item type was fixed by the patch, as required. Before applying the patch, the error occurred either adding from a staged file with items (as by the test plan) or adding from a staged file without items. The error about displying dropdown lists is fixed in both these two cases. So I pass the patch to "Signed Off" status. ---------------------------------------------------------------------- NB. Either in master or after having applied the patch, ordering from a staged record with items adds no item. This is different from importing in the catalog: a staged record with items is imported in the catalog with all its items. On Tools, the"Stage MARC records for import" works well: after uploading a local file with items (with 952 and some subfields among 952$i, 952$o, 952$p, 952$r, 952$t, 952$w, 952$y, 952$z etc) the "MARC staging results" says (and it's true): [...] 1 item records found and staged [...] On ACQ, ordering from the staged file with items: A) in "Select to import" tag, the "MARC" view of the staged record shows no 952 field (ERROR?); B) in "Item information" tag, all the item's fields i (i.e.: i - Inventory number, o - Full call number, p - Barcode, t - Copy number, y - Koha item type, etc ) are shown empty (ERROR?); C) in "Select on import" tag, if I select "Add order" [and I "Create new record"], only the "Catalog details" fields are filled, whilst the "Item" fields are all empty (ERROR?). --------------------------------------------------------------------- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31915|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31925&action=edit Bug 12927: Problems with item information tab on acq order from staged page This patch fixes a regression introduced (by me) on Bug 12673. I adds the code needed to display properly all fields To test: 1) Check that 'AcqCreateItem' syspref is set to 'placing an order' 2) Satage a file with some items 3) Go to a Vendor, create a basket, clic add from staged file, select your file 4) On 'Item information' tab fields are displayed wrong 5) Apply the patch 6) Reload, display must now be fixed Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch fixes the described issue but the one raised on comment 12673 comment 11 is still valid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #5)
This patch fixes the described issue but the one raised on comment 12673 comment 11 is still valid.
Forget that, it fixes exactly this issue. I mistook with another one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13008 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12927 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 13008 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org