[Bug 28581] New: Patron's queue_notice uses inbound_email_address incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Bug ID: 28581 Summary: Patron's queue_notice uses inbound_email_address incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org See also bug 28514 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28514 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, I agree the use in queue_notice is incorrect. I'll submit a patch to fix that and try to improve the POD of inbound_email_address to further clarify it. Perhaps a 'from_email_address' method might help clarify things too? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Koha::Patron seems to be the only place where we use the inbound_email routine as a from address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122056&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122056|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122057&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sorry, still working here too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122057|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122061&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122062&action=edit Bug 28581: Do not send mail without a from address Test plan: Make branch mail empty and KohaAdminEmailAddress. Trigger a message that goes thru the message queue. Check the log for a warning. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122063&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few trivial cases now. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122061|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122067&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122063|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122068&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122071&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122071|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122072&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122067|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122073&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122068|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122074&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122072|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122075&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122076&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 122078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122078&action=edit Bug 28581: Enhance POD for EnqueueLetter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think between Marcel and I we've signed off each others patches and worked through it together to catch all the edge cases.. Setting to signed off and asking Tomas and Nick to take a look for QA as they've both recently been involved in notice related code close to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [15:51] <marcelr> ashimema: misc/cronjobs/notice_unprocessed_suggestions.pl [15:52] <marcelr> do you intently leave from now empty ?? [15:52] == magnuse [~magnuse@89-162-88-217.fiber.signal.no] has joined #koha [15:52] == mode/#koha [+o magnuse] by ChanServ [15:52] <marcelr> + my $admin_email_address = $library->from_email_address [15:52] <marcelr> no comma at the end [15:52] <marcelr> in overdue [15:53] <marcelr> same question for suggestion as for unprocessed sugg [15:53] <marcelr> from is empty now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122076|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122080&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a semicolon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122078|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122081&action=edit Bug 28581: Enhance POD for EnqueueLetter Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #19)
[15:51] <marcelr> ashimema: misc/cronjobs/notice_unprocessed_suggestions.pl [15:52] <marcelr> do you intently leave from now empty ?? [15:52] == magnuse [~magnuse@89-162-88-217.fiber.signal.no] has joined #koha [15:52] == mode/#koha [+o magnuse] by ChanServ [15:52] <marcelr> + my $admin_email_address = $library->from_email_address [15:52] <marcelr> no comma at the end [15:52] <marcelr> in overdue [15:53] <marcelr> same question for suggestion as for unprocessed sugg [15:53] <marcelr> from is empty now
Semicolon fixed. Two empties are intended; will be filled when sending.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122073|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122136&action=edit Bug 28581: Add 'from_email_address' method and use in Koha::Patron This patch adds a new 'from_email_address' method to Koha::Library to return the appropriate email address to use as the 'from' field for email notices from the library. We then update Koha::Patron->queue_notice to use this new method instead of the incorrect inbound_email_address. I also update the POD for inbound_email_address to clarify it's use case. Test plan Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122074|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122137&action=edit Bug 28581: Use from_email_address in the codebase Adding only a few (trivial) cases now. Changes in C4::Letters are not trivial after all.. We now add the KohaAdminEmail fallback implicitly when the from address was still empty. The extra check makes us not rely on a do or die action in Email::Stuffer. Test plan: Run password recovery or membership expiry cron. Check sender address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122075|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122138&action=edit Bug 28581: (QA follow-up) Prevent code failure This patch prevents a fatal error when both $params->{from} and $params->{borrowernumber} are undefined. We fallback to KohaAdminEmailAddress before finally falling through to setting a failure status for the message if that last fallback is not found. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122080|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122139&action=edit Bug 28581: Use 'from_email_address' where appropriate This patch replaces a few more trivial cases where we were using library->branchemail with a fallback to KohaAdminEmail to just use the new library->from_email_address method directly instead. There were also a couple of cases where we were passing borrowernumber and the patrons library from address too.. this is unneccesary as the code in _send_email_massage will already default to patron library from address if we do not pass an override. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Added a semicolon. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122081|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122140&action=edit Bug 28581: Enhance POD for EnqueueLetter Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Comment on attachment 122139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122139 Bug 28581: Use 'from_email_address' where appropriate Review of attachment 122139: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28581&attachment=122139) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1849,4 @@
my $library = Koha::Libraries->find( $hold->branchcode )->unblessed;
+ my $admin_email_address = $library->from_email_address;
Hum, $library is a hashref here. # Failed test 'Set waiting flag' # at /kohadevbox/koha/t/db_dependent/Circulation.t line 3475. Can't call method "from_email_address" on unblessed reference at /kohadevbox/koha/C4/Reserves.pm line 1852. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122212&action=edit Bug 28581: (QA follow-up) Fix method on unblessed reference Speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Test still fails on problem with Renewal but waiting flag passes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- # Subtest: AddRenewal and AddIssuingCharge tests 1..13 not ok 1 - Exception is thrown when renewal update to issues fails # Failed test 'Exception is thrown when renewal update to issues fails' # at t/db_dependent/Circulation.t line 3912. # expecting: Koha::Exceptions::Checkout::FailedRenewal # found: normal exit ok 2 - renew log not added because of the syspref RenewalLog ok 3 - AddRenewal should set the renewal date with the time part not ok 4 # Failed test at t/db_dependent/Circulation.t line 3935. # got: '3' # expected: '2' ok 5 - The issue of item with issuing charge generates an accountline of the correct type ok 6 - AddIssuingCharge correctly sets branchcode ok 7 - AddIssue does not set a hardcoded description for the accountline ok 8 - The renewal of item with issuing charge generates an accountline of the correct type ok 9 - AddRenewal correctly sets branchcode ok 10 - AddRenewal does not set a hardcoded description for the accountline ok 11 - renew log successfully added ok 12 - renew statistic successfully added with passed branch not ok 13 - Passing skipfinecalc causes fine calculation on renewal to be skipped # Failed test 'Passing skipfinecalc causes fine calculation on renewal to be skipped' # at t/db_dependent/Circulation.t line 3972. # got: '6' # expected: '5' # Looks like you failed 3 tests of 13. not ok 42 - AddRenewal and AddIssuingCharge tests # Failed test 'AddRenewal and AddIssuingCharge tests' # at t/db_dependent/Circulation.t line 3974. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED Version(s)|21.11.00 | released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #30)
Test still fails on problem with Renewal but waiting flag passes.
Not pushing then. I don't recreate however. How did you get it failing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #33)
(In reply to Marcel de Rooy from comment #30)
Test still fails on problem with Renewal but waiting flag passes.
Not pushing then. I don't recreate however. How did you get it failing?
It fails with me without this patch set too. Not sure. Bad data? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #34)
(In reply to Jonathan Druart from comment #33)
(In reply to Marcel de Rooy from comment #30)
Test still fails on problem with Renewal but waiting flag passes.
Not pushing then. I don't recreate however. How did you get it failing?
It fails with me without this patch set too. Not sure. Bad data?
Yes I think so, maybe a pref did not have the default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we tell how long this was broken and if the change is required in 20.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 [Bug 15986] Add a script for sending hold waiting reminder notices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #38)
Can we tell how long this was broken and if the change is required in 20.11?
queue_notice was introduced with bug 15986 which only appeared in 21.05.. so this shouldn't need porting to 20.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #40 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 15986 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28581 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29223 [Bug 29223] Auto-renewals can fail when not digested per branch and patron requests digest -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org