https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23833 Depends on|15850 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 [Bug 15850] Correct eslint errors in cataloging.js https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112007&action=edit Bug 25353: Correct eslint errors in additems.js This patch makes minor changes to additem.js to correct errors highlighted by eslint: - Consistent indentation - Notation of global and exported variables and functions - Consistent use of the "var" declaration for all new variables - Remove variables from function calls which aren't used To test, apply the patch and use your preferred eslint-enabled tool to check for errors. There should be none. If you don't have eslint integrated in your development environment you could use the online ESLint demo at https://eslint.org/demo. The demo isn't configured to assume a browser environment with jQuery present, so you'll have to modify the top line after pasting the contents of additem.js: /* global $ alert window __ */ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112260|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 112359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112359&action=edit Bug 25353: Correct eslint errors in additems.js This patch makes minor changes to additem.js to correct errors highlighted by eslint: - Consistent indentation - Notation of global and exported variables and functions - Consistent use of the "var" declaration for all new variables - Remove variables from function calls which aren't used To test, apply the patch and use your preferred eslint-enabled tool to check for errors. There should be none. If you don't have eslint integrated in your development environment you could use the online ESLint demo at https://eslint.org/demo. The demo isn't configured to assume a browser environment with jQuery present, so you'll have to modify the top line after pasting the contents of additem.js: /* global $ alert window __ */ Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25353 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.