[Bug 38297] New: The "New vendor" button needs a permissions guard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Bug ID: 38297 Summary: The "New vendor" button needs a permissions guard Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org There is no check for the vendors_manage permission to render the New vendor button on the acquisitions homepage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173710&action=edit Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173710|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 173711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173711&action=edit Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173711|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173713&action=edit Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173713|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173763&action=edit Bug 38297: Add a permissions check to the New vendor button Test plan: 1) Choose a staff patron and make sure they have permissions to log into the staff interface 2) Ensure that the patron does not have the vendors_manage permission but give them one other acquisitions permission so that they can see the link on the homepage (e.g. budget_manage) 3) In an incognito browser, log in with that patron and go to the acquisitions homepage 4) The New vendor button will be visible 5) Click on it and fill in the required fields. Submit the form and it will error for lack of permissions 6) Apply patch 7) Return to the acquisitions page and the New vendor button should no longer be visible 8) Back in your main browser, give the patron the vendors_manage permission and then refresh the incognito window - the button should be visible Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Keywords|roadmap_24_11 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38297 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse@bywatersolutions.com Status|Pushed to oldoldstable |RESOLVED --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org