[Bug 18922] New: Mana - Share review
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Bug ID: 18922 Summary: Mana - Share review Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org This module add reviews for Mana -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 --- Comment #1 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64958&action=edit Bug 18922: Share review with Mana This add reviews sharing with Mana. Test plan: 1 - Check Bug 17057 is installed and works on your Koha 2 - Apply patch 3 - Activate Review Sharing with Mana (AutoShareWithMana => review) 4 - Comment a resource of your database and check you authorize sharing with Mana 5 - As librarian, validate the comment 6 - If you go again on the notice you should see the comment 7 - Try again step 4-6 without accepting to share with Mana => it won't share Note: The resource must have a valid isbn/issn/ean in the database field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 --- Comment #2 from Baptiste <baptiste.wojtkowski@biblibre.com> --- Created attachment 64959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64959&action=edit Bug 18922: Dbix updates This is the dbix update so you don't have to run the script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 Patch complexity|--- |Small patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Baptiste <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|baptiste.wojtkowski@biblibr |koha-bugs@lists.koha-commun |e.com |ity.org CC| |victor.grousset@biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Hugo Agud <hagud@orex.es> --- Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 19474: (follow-up) Compiled CSS The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19474-follow-up-Compiled-CSS-hIYP0p.patch Cannot apply cleanly patches from bug 19474. Everything will be left dirty. git bz apply --continue will not continue the process if patches from other bug reports need to be applied. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Bug 18922 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64958|0 |1 is obsolete| | --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 186971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186971&action=edit Bug 18922: Share review with Mana This add reviews sharing with Mana. Test plan: 1 - Apply patch 2 - Activate Review Sharing with Mana (AutoShareWithMana => review) 3 - Comment a resource of your database and check you authorize sharing with Mana 4 - As librarian, validate the comment 5 - If you go again on the notice you should see the comment 6 - Try again step 4-6 without accepting to share with Mana => it won't share Note: The resource must have a valid isbn/issn/ean in the database field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186971|0 |1 is obsolete| | --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 186972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186972&action=edit Bug 18922: Share review with Mana This add reviews sharing with Mana. Test plan: 1 - Apply patch 2 - Activate Review Sharing with Mana (AutoShareWithMana => review) 3 - Comment a resource of your database and check you authorize sharing with Mana 4 - As librarian, validate the comment 5 - If you go again on the notice you should see the comment 6 - Try again step 4-6 without accepting to share with Mana => it won't share Note: The resource must have a valid isbn/issn/ean in the database field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 186973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186973&action=edit Bug 18922: Share review with Mana This add reviews sharing with Mana. Test plan: 1 - Apply patch 2 - Activate Review Sharing with Mana (AutoShareWithMana => review) 3 - Comment a resource of your database and check you authorize sharing with Mana 4 - As librarian, validate the comment 5 - If you go again on the notice you should see the comment 6 - Try again step 4-6 without accepting to share with Mana => it won't share Note: The resource must have a valid isbn/issn/ean in the database field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64959|0 |1 is obsolete| | Attachment #186972|0 |1 is obsolete| | Attachment #186973|0 |1 is obsolete| | --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 186974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186974&action=edit Bug 18922: Share review with Mana This add reviews sharing with Mana. Test plan: 1 - Apply patch and run "dbic" 2 - Activate Review Sharing with Mana (AutoShareWithMana => review) 3 - Comment a resource of your database and check you authorize sharing with Mana 4 - As librarian, validate the comment 5 - If you go again on the notice you should see the comment 6 - Try again step 4-6 without accepting to share with Mana => it won't share Note: The resource must have a valid isbn/issn/ean in the database field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Automatic patch test results: â ï¸ The patch applies with fuzzy option (ignoring whitespace). This may indicate minor conflicts that need to be resolved. Details: Patch applies with fuzzy option (ignoring whitespace) This is an automated message from the patch testing system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- We got an error on the DB update, had to remove the quotes around the statements inside the q{}: $dbh->do(q{'ALTER TABLE reviews ADD COLUMN share_auth integer'}); to $dbh->do(q{ALTER TABLE reviews ADD COLUMN share_auth integer}); But then on the opac we got an error: Undefined subroutine &Koha::SharedContent::manaRequest called at /kohadevbox/koha/opac/opac-detail.pl line 930 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18922 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Just passing by and looked at the DB changes: the kohastructure.sql is missing. The new column is a boolean so this applies: https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org