http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 14552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14552&action=edit Bug 9383 - Bad logic, missing params, and irregular labeling for Members scripts To test: Before patch: 1) Add new patrons with "organization", "adult", and "professional" category types/codes. 2) Observe that they all have input boxes for Primary phone, Secondary phone, and Other phone. 3) Also, observe that they all have input boxes for Primary email, and Secondary email 4) Save the patron and look at the Details page that should come up automatically 5) Note that your "Secondary Phone" now shows up as "Other Phone" and your "Other phone" shows up as "Secondary Phone". --- After Patch: 1) Organization will have input boxes for "Organization phone" and "Organization" email, which correspond to the (Primary) phone/email fields. 2) Professionals will have input boxes for Primary/Secondary phones (but not Mobile phones) which correspond to phone/phonepro DB fields. 3) Other patrons will have input boxes for Primary/Secondary/Mobile, which correspond to phone, phonepro, mobile DB fields. --- Personally, I don't see why Professionals should be separated from the rest of patrons (other than Organizations). In fact, I don't know if there is even a point separating Organizations! I think Primary/Secondary/Mobile are fine clear across the board. So maybe a follow-up to this would actually eliminate the conditions for "I" (organization) and "P" (professional) while retaining the consistent labelling between the memberentrygen.pl and moremember.pl files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to comment #2)

(In reply to comment #1)

...

Personally, I don't see why Professionals should be separated from the rest of patrons (other than Organizations). In fact, I don't know if there is even a point separating Organizations! I think Primary/Secondary/Mobile are fine clear across the board.

Professional type patrons can be created with links to specific Organizations. I don't know much about how this works in practice but it's obviously a feature which was created with specific intent.

I agree, Owen, but I was referring to the separation of phone/email labels rather than the actual patron types. I don't know why an organisation would need "organisation phone" rather than "primary phone" or why a professional would have different labels for the same fields as any other individual patron. I think there might be some disagreement about which labels I've chosen to apply in this patch (like using Mobile Phone for mobilephone, as I think some people prefer to use Other phone as mobilephone might actually be the Primary Phone). However, the current templates don't actually work to differentiate them anyways at the moment, because the categorycode param isn't passed to the template from the perl. Besides that, the labels appear to be inconsistent between the patron entry page and the patron detail page. I imagine it would be disconcerting to put your work phone as your primary phone and then have your home phone show up as your primary phone on your page. (Mind you, that's awfully detail-oriented, so maybe most people wouldn't notice.) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- What does this change to memberentry + "$category_type" => 1, #passes category type (e.g. C, A, S, P, I, X) to template like in moremember.pl do? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Looking again at these changes and trying to figure out the logic of which fields should be displayed for which types makes me think you're right in wondering why we try to change the display for different patron types. Maybe we should take a step back and try to isolate what differences are really necessary and what differences might have originated with some library's specific needs. Some starting assumptions: - Any category type could easily have any kind of contact information. - Child patrons and Professional patrons need to show guarantor information - Organizations should not have the same name fields humans have Another idea: Making BorrowerUnwantedField and BorrowerMandatoryField configurable at the patron-category level would offer libraries better control over the decisions that the template currently makes for them. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9383 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12407 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- This bug partially solved by bug 12407 -- You are receiving this mail because: You are watching all bug changes.