[Bug 12512] New: PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bug ID: 12512 Summary: PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 12233 The Bootstrap theme doesn't have a binary distinction between "desktop" and "mobile," so the OpacShowFiltersPulldownMobile system preference doesn't make sense to have anymore. With CCSR deprecated the OpacShowFiltersPulldownMobile system preference can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29417&action=edit Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29417|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29471&action=edit [SIGNED-OFF] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Preference removed, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29471|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29482&action=edit [PASSED QA] Bug 12512 - PROG/CCSR deprecation: Remove OpacShowFiltersPulldownMobile system preference CCSR having been deprecated there is no longer a use for the OpacShowFiltersPulldownMobile system preference. This patch removes it. To test, apply the patch and run updatedatabase. Check that the preference can no longer be found in system preferences. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to MM_OPAC/theme_dep Note please do not merge this branch yet, until I have all the prog/ccsr patches on there, and have them all working happily together -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- This is quite safe, have moved this straight to master, will apply the others on only on the MM_OPAC/them_dep branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Bug 12512 depends on bug 12233, which changed state. Bug 12233 Summary: remove prog and CCSR OPAC themes http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12512 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org