https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Patrons Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- This error is triggered when patron added as guarantor is a child OR has categorycode which has setting "can_be_guarantee" on. So it's still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32980 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- As a side note, I realized that we don't really need to check if patron is child when "ChildNeedsGuarantor" is enabled. It's enough to check if patrons category has "Can be guarantee" set. Secondly, I'm now second guessing this line: if ( ( $op eq 'save' || $op eq 'insert' ) && $guarantor->is_child || $guarantor->category->can_be_guarantee ) { push @errors, 'ERROR_guarantor_is_guarantee'; } In this too, we could get rid of $guarantor->is_child. And yeah, I can see where the confusion comes. This doesn't prevent all situations where of someone being both guarantee and guarantor. They can be also guarantor as long as their category type doesn't have "Can be guarantee" set. And "ChildNeedsGuarantor" and error "Child patron needs guarantor." have to be changed. Actually, I'm not sure anymore if "ChildNeedsGuarantor" should be a global syspref. Instead it should be category specific like "Can be guarantee" (something like "Guarantor is mandatory"). It would be more flexible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Button "+ add guarantee" appears when patron.is_adult meaning in category type A or I. This must depend on patron category having not "Can be guarantee" right ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #7 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- There’s another bug related to patrons in the same category not being able to be guarantor and guarantee. Maybe it would be worth waiting for that fix before making any decisions. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37892 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35421 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 37892 pushed and says "Guarantor cannot be a guarantee" right ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.