[Bug 12663] New: SCOUserCSS and SCOUserJS ignored on selfcheck login page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Bug ID: 12663 Summary: SCOUserCSS and SCOUserJS ignored on selfcheck login page. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org The two preferences: SCOUserCSS and SCOUserJS --- Do not apply to the selfcheck login page. To reproduce: * Make changes using above prefs * GOTO selfcheck module: http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl If you have not logged in, your changes will not be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jweaver@bywatersolutions.co |ity.org |m CC| |jweaver@bywatersolutions.co | |m, | |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46736&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.pl and SCOUserCSS and SCOUserJS are not loaded. This patch adds new opac-auth.tt file for authenticating SCO users which loads these files and redirects a login to the SCO module instead of the patron account Common code between opac-auth and sco-auth is mostly alternate login info and has been move to alt-auth.inc To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO login goes to a new page 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Bonus points for verifying all alternate methonds of login function as expected Sponsored by Northeast Kansas Libary System (NEKLS) www.nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver@bywatersolutions.co |nick@bywatersolutions.com |m | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 46736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46736 Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Review of attachment 46736: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12663&attachment=46736) ----------------------------------------------------------------- ::: C4/Auth.pm @@ +1250,5 @@
PatronSelfRegistrationDefaultCategory => C4::Context->preference("PatronSelfRegistrationDefaultCategory"), persona => C4::Context->preference("Persona"), opac_css_override => $ENV{'OPAC_CSS_OVERRIDE'}, + SCOUserCSS => C4::Context->preference("SCOUserCSS"), + SCOUserJS => C4::Context->preference("SCOUserJS"),
There is no need to pass system preferences. Use Koha.Preference calls in the Template Toolkit files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46736|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47270&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.pl and SCOUserCSS and SCOUserJS are not loaded. This patch adds new opac-auth.tt file for authenticating SCO users which loads these files and redirects a login to the SCO module instead of the patron account Common code between opac-auth and sco-auth is mostly alternate login info and has been move to alt-auth.inc To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO login goes to a new page 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page Bonus points for verifying all alternate methonds of login function as expected Sponsored by Northeast Kansas Libary System (NEKLS) www.nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to M. Tompsett from comment #2)
There is no need to pass system preferences. Use Koha.Preference calls in the Template Toolkit files. Fixed the calls I added, thanks Mark!
-- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org