[Bug 28962] New: Make deleting unverified self registrations standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Bug ID: 28962 Summary: Make deleting unverified self registrations standard (see del-unv-selfreg / DeleteUnverifiedOpacRegistrations) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The flag del-unv-selfreg could be inserted into the standard set of the cleanup database cron job. The verification mail tells us: If you did not initiate this request, you may safely ignore this one-time message. The request will expire shortly. This actually is not true. But we could make it a bit more true when deleting them by default within say 14 days? Of course this could always become a syspref one day :) Note that running this sub when you do not use self registration does not hurt. It only selects the records without a borrowernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Ha, the advertized --del-unv-selfreg DAYS Delete unverified self registrations older than DAYS does not even work ! The cmdline value is silently ignored. Will fix that too now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124617&action=edit Bug 28962: Add del-unv-selfreg to crontab We also add a test by inserting a simulated borrower modification record in the same table which should not be deleted. NOTE: This patch fixes the del-unv-selfreg parameter in the cleanup db script. It did not even do what it promised :) Test plan: Verify if the crontab change is correct. Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This report makes the release notes| |del-unv-selfreg flag of the | |cleanup_database script | |part of the standard | |crontab of Koha. | | | |It | |defaults to 14 days. | | | |Note: | |If you do not use self | |registration with | |verification mail, this | |does not affect you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I have intentionally kept the BUG flag instead of ENH since this fixes a tiny but very sloppy bug in the cleanup_database parameter setting of this flag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make deleting unverified |Unverified self |self registrations standard |registrations should be |(see del-unv-selfreg / |removed shortly |DeleteUnverifiedOpacRegistr | |ations) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124617|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 128704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128704&action=edit Bug 28962: Add del-unv-selfreg to crontab We also add a test by inserting a simulated borrower modification record in the same table which should not be deleted. NOTE: This patch fixes the del-unv-selfreg parameter in the cleanup db script. It did not even do what it promised :) Test plan: Verify if the crontab change is correct. Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the|This report makes the |This fixes the release notes|del-unv-selfreg flag of the |cleanup_database script so |cleanup_database script |that the option to delete |part of the standard |unverified self |crontab of Koha. |registrations | |(del-unv-selfreg) works. It |It |also adds this option to |defaults to 14 days. |the standard crontab, | |defaulting to 14 days (the |Note: |default notice says |If you do not use self |unverified registrations |registration with |will expire "shortly"). |verification mail, this | |does not affect you. |Note: If you don't use self | |registration with a | |verification email, this | |does not affect you. If you | |do use self registration, | |check the system | |preferences and settings - | |particularly | |PatronSelfRegistrationDefau | |ltCategory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|robin@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #5 from David Nind <david@davidnind.com> --- The crontab entry looks fine to me. The tests pass. No updates are required to the cron jobs and crontab sections of manual. The flag is already covered in the description of the script, although it doesn't work! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #4)
Signed-off-by: David Nind <david@davidnind.com>
Thx for your signoff's, David ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Not a big deal I think, but prior to this patch we were actually removing faster as the "default" was 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Also note that with this patch the script will now fail (displaying the help) if the flag is called without value. I don't think we should backport this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128704|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129377&action=edit Bug 28962: Add del-unv-selfreg to crontab We also add a test by inserting a simulated borrower modification record in the same table which should not be deleted. NOTE: This patch fixes the del-unv-selfreg parameter in the cleanup db script. It did not even do what it promised :) Test plan: Verify if the crontab change is correct. Run t/db_dependent/Members.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
Not a big deal I think, but prior to this patch we were actually removing faster as the "default" was 1.
This is arguable. First, saying that "default" is 1 leans on the true value (not a great feature). But more importantly, the crontab did not include this flag. So unless an admin added it, the records were not deleted at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
Also note that with this patch the script will now fail (displaying the help) if the flag is called without value. I don't think we should backport this.
Agreed. Moving to enh. (Altough it fixes a bug..) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28962 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org