[Bug 11812] New: Add missing "required" indicator to fields which are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Bug ID: 11812 Summary: Add missing "required" indicator to fields which are required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Some form fields are configured to be required but lack the "required" note next to them. Since the red label color may not be immediately understood to indicate that a field is required the "required" text should be present too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25543&action=edit Bug 11812 - Add missing "required" indicator to fields which are required Form fields in the staff client which are required should be configured to be so by doing several things: - Add a class "required" to the field's <label> - Add a class "required" to the form field - Add 'required="required"' to the form field - Apppend a <span class="required">Required</span> after the form field. Several places in the templates are missing the <span>. This patch adds them. To test, apply the patch and view the following pages to confirm that the "Required" text appears: - Acquisitions -> Add an order to a basket from a new (empty) record. Title, quantity, and fund should indicate they are required. - Administration -> Authority types -> New authority type. The authority type and description fields should indicate they are required. - Administration -> Authority types -> MARC structure -> New tag. The tag field should indicate it is required. - Patron types and categories -> New category. Category code, description, and category type should indicate that they are required. FIXME: Enrollment period is required but the user must choose one. I'm not sure how to handle that clearly. - Tools -> CSV profiles. Profile name, profile type, and profile MARC fields should indicate they are required on both the new and edit forms. - Administration -> Manage MARC modification templates. Under "Create a new template" the name field should indicate that it is required. - Tools -> Batch patron modification -> Submit a batch for editing. Any fields which are required according to your BorrowerMandatoryField system preference should indicate that they are required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 25560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25560&action=edit [SIgned-off] Bug 11812 - Add missing "required" indicator to fields which are required Form fields in the staff client which are required should be configured to be so by doing several things: - Add a class "required" to the field's <label> - Add a class "required" to the form field - Add 'required="required"' to the form field - Apppend a <span class="required">Required</span> after the form field. Several places in the templates are missing the <span>. This patch adds them. To test, apply the patch and view the following pages to confirm that the "Required" text appears: - Acquisitions -> Add an order to a basket from a new (empty) record. Title, quantity, and fund should indicate they are required. - Administration -> Authority types -> New authority type. The authority type and description fields should indicate they are required. - Administration -> Authority types -> MARC structure -> New tag. The tag field should indicate it is required. - Patron types and categories -> New category. Category code, description, and category type should indicate that they are required. FIXME: Enrollment period is required but the user must choose one. I'm not sure how to handle that clearly. - Tools -> CSV profiles. Profile name, profile type, and profile MARC fields should indicate they are required on both the new and edit forms. - Administration -> Manage MARC modification templates. Under "Create a new template" the name field should indicate that it is required. - Tools -> Batch patron modification -> Submit a batch for editing. Any fields which are required according to your BorrowerMandatoryField system preference should indicate that they are required. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25543|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) MARC modification templates - 'This field is required' is not bold like on other pages. 2) Batch patrons modification - I am not sure if the markup here is not misleading. The fields are required, so you are not allowed to delete their content, but you are not required to actually add something into the fields on this form. You can leave them empty. 3) Some pages still have the Javascript pop up while others do not, but I assume this is going to be tackled with other patches :) Failing for 2) - Owen, could you take a look please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25560|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32302&action=edit [SIGNED-OFF] Bug 11812 - Add missing "required" indicator to fields which are required [SIGNED-OFF] Bug 11812 - Add missing "required" indicator to fields which are required Form fields in the staff client which are required should be configured to be so by doing several things: - Add a class "required" to the field's <label> - Add a class "required" to the form field - Add 'required="required"' to the form field - Apppend a <span class="required">Required</span> after the form field. Several places in the templates are missing the <span>. This patch adds them. To test, apply the patch and view the following pages to confirm that the "Required" text appears: - Acquisitions -> Add an order to a basket from a new (empty) record. Title, quantity, and fund should indicate they are required. - Administration -> Authority types -> New authority type. The authority type and description fields should indicate they are required. - Administration -> Authority types -> MARC structure -> New tag. The tag field should indicate it is required. - Patron types and categories -> New category. Category code, description, and category type should indicate that they are required. FIXME: Enrollment period is required but the user must choose one. I'm not sure how to handle that clearly. - Tools -> CSV profiles. Profile name, profile type, and profile MARC fields should indicate they are required on both the new and edit forms. - Administration -> Manage MARC modification templates. Under "Create a new template" the name field should indicate that it is required. - Tools -> Batch patron modification -> Submit a batch for editing. Any fields which are required according to your BorrowerMandatoryField system preference should indicate that they are required. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> QA Edits: Re-worded the "required" not on the batch patron edit form, added a missing word to the help text on that page. On the csv-profiles page I removed an unnecessary "javascript:" protocol from the markup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is something a bit different on the patron category form - if you try saving without filling out any of the fields, the markup doesn't change - there is no additional note or highlighting appearing. I am still going to pass this, as this is just a small visual problem, but overall I found no regressions or problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32311&action=edit [PASSED QA] Bug 11812 - Add missing "required" indicator to fields which are required Form fields in the staff client which are required should be configured to be so by doing several things: - Add a class "required" to the field's <label> - Add a class "required" to the form field - Add 'required="required"' to the form field - Apppend a <span class="required">Required</span> after the form field. Several places in the templates are missing the <span>. This patch adds them. To test, apply the patch and view the following pages to confirm that the "Required" text appears: - Acquisitions -> Add an order to a basket from a new (empty) record. Title, quantity, and fund should indicate they are required. - Administration -> Authority types -> New authority type. The authority type and description fields should indicate they are required. - Administration -> Authority types -> MARC structure -> New tag. The tag field should indicate it is required. - Patron types and categories -> New category. Category code, description, and category type should indicate that they are required. FIXME: Enrollment period is required but the user must choose one. I'm not sure how to handle that clearly. - Tools -> CSV profiles. Profile name, profile type, and profile MARC fields should indicate they are required on both the new and edit forms. - Administration -> Manage MARC modification templates. Under "Create a new template" the name field should indicate that it is required. - Tools -> Batch patron modification -> Submit a batch for editing. Any fields which are required according to your BorrowerMandatoryField system preference should indicate that they are required. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> QA Edits: Re-worded the "required" not on the batch patron edit form, added a missing word to the help text on that page. On the csv-profiles page I removed an unnecessary "javascript:" protocol from the markup. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works and passes QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32302|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11812 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org