[Bug 10794] New: Sorting on billing date column in invoices table doesn't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Bug ID: 10794 Summary: Sorting on billing date column in invoices table doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/invoices.pl?supplierid=2&op=do_sea rch OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Sorting by billing date in the invoices table in acquisitions doesn't work. In my case there was only one date and the other fields were empty. Sorting the column didn't result in any change. Other columns sort nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20924&action=edit Bug 10794 - Sorting on billing date column in invoices table doesn't work This patch adds the sorting by title string option to the table of invoices. This allows column data to be sorted based on the ISO-formatted date rather than the formatted-for-display date. A "blank" (0000-00-00) date is added to cells which contain no date data. To test, view the Acquisitions Invoices page (acqui/invoices.pl) and confirm that the "Billing date" column is sorted correctly regardless of the dateformat system preference. http://bugs.koha-community.org/show_bug.cgi?id=10749 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20924|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 21738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21738&action=edit [SIGNED-OFF] Bug 10794 - Sorting on billing date column in invoices table doesn't work This patch adds the sorting by title string option to the table of invoices. This allows column data to be sorted based on the ISO-formatted date rather than the formatted-for-display date. A "blank" (0000-00-00) date is added to cells which contain no date data. To test, view the Acquisitions Invoices page (acqui/invoices.pl) and confirm that the "Billing date" column is sorted correctly regardless of the dateformat system preference. http://bugs.koha-community.org/show_bug.cgi?id=10749 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21738|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21830&action=edit Bug 10794 - Sorting on billing date column in invoices table doesn't work This patch adds the sorting by title string option to the table of invoices. This allows column data to be sorted based on the ISO-formatted date rather than the formatted-for-display date. A "blank" (0000-00-00) date is added to cells which contain no date data. To test, view the Acquisitions Invoices page (acqui/invoices.pl) and confirm that the "Billing date" column is sorted correctly regardless of the dateformat system preference. http://bugs.koha-community.org/show_bug.cgi?id=10749 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change, passes all tests and QA script. Sorting of the billing column now works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |9505 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway@gmail.com --- Comment #6 from Joseph Alway <jbalway@gmail.com> --- This bug is still showing up in Koha 3.14 and 3.14.3. It seems like the patch should have been implemented in one of the more recent updates, but it has not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #7 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- It was implemented and it worked, at least for a while ;) But indeed, it's not working properly since "Bug 10401: Add ability to merge invoices" has been pushed - there was 1st extra column with checkboxes added, and this code $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, { sDom: "t", "aoColumns": [ null,null,{ "sType": "title-string" },null,null,null,null ], aoColumnDefs: [ { "bSortable": false, "aTargets": [0, 7] } ] })); was not fully adjusted to reflect this change ( "sType": "title-string" now applies to "Vendor" column, not "Billing date"). BTW, I think it may be something else not quite right with this code; that's what I'm getting in 3.14 and in (not so current) master: 1) "Billing date" sorting is not OK, 2) "Vendor" column is not sortable at all, 3) top/bottom DataTables pagination bars are missing (tested in Firefox 27.0, might be browser dependant?) - only "top ten" invoices are always displayed in the table, and it's not possible to change that without pagination bars. By some trial-and-error, I got it working (1-3) with: $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, { aoColumnDefs: [ { "bSortable": false, "aTargets": [0, 7] }, { "sType": "string", "aTargets": [ 3 ] } ] })); but it's my first real experience with DataTables; not sure if I know what I'm doing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #8 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- Or perhaps something like this $("#resultst").dataTable($.extend(true, {}, dataTablesDefaults, { bPaginate: false, sDom: "t", aoColumnDefs: [ { "bSortable": false, "aTargets": [0, 7] }, { "sType": "string", "aTargets": [ 3 ] } ] })); will be better (= no pagination bars/no filter on table, but all rows being displayed, not just top 10)? Unless "top ten rows only display" is a feature, and not a bug? If so, personally I find it not very intuitive.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #9 from Joseph Alway <jbalway@gmail.com> --- Yeah, I did notice that it was only displaying 10 items and there was no option to show the rest. Which would be another bug. Unless they are being caused by the same thing. I tested it in Firefox and Google Chrome, so I would guess that the Data Table Pagination bars are not a browser issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #10 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Joseph Alway from comment #9)
Yeah, I did notice that it was only displaying 10 items and there was no option to show the rest. Which would be another bug. Unless they are being caused by the same thing.
Still don't know if the "top 10 only display" is a bug or a feature but I made a patch to fix both issues; see bug 11798. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11798 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794 --- Comment #11 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Joseph Alway from comment #9) BTW (on a not quite related subject - but we'll be grateful if someone can shed some light on this mystery) we/our translation people were wondering what is the precise meaning of the "Billing date": - date the invoice was issued by vendor, - date the invoice was shipped to/given to, or arrived to the client, - date the payment is due, - date the payment was actually made ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org