[Bug 10190] Overdue notice triggers based on item type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 --- Comment #947 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 205163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205163&action=edit Bug 10190: (QA follow-up): fix: anchor circulation triggers on .pl admin-home.tt, the Vue router base path, and one router.push in CirculationTriggersFormAdd.vue link to the pretty /cgi-bin/koha/admin/circulation_triggers URL, which only resolves via a RewriteRule that never reaches an already-installed site on package upgrade. This is what comment 192 hits. Point all three at circulation_triggers.pl instead, same convention SIP2 and ERM use for their base route: reachable via Apache's default cgi-bin routing, no RewriteRule needed. Sub-routes (add/edit/etc.) stay under circulation_triggers.pl too, so the URL bar shows .pl throughout rather than just on initial load. Update Cypress spec URLs to match. The old RewriteRule (^/cgi-bin/koha/admin/circulation_triggers(.*)?$ -> circulation_triggers.pl$1 [PT]) is now both unused and actively harmful: it matches its own rewrite target, so hitting circulation_triggers.pl directly gets rewritten to circulation_triggers.pl.pl, which does not exist, 404. Remove it from debian/templates/apache-shared-intranet.conf and etc/koha-httpd.conf. Test plan: 1. Starting from a migration (apply all patches, yarn api:bundle, yarn js:build, updatedatabase, restart_all): 2. Go to Administration, click 'Circulation triggers'. Confirm it loads with no 404 (URL bar shows circulation_triggers.pl) 3. Add a new trigger and save. Confirm it saves with no routing errors 4. prove xt/check_apache_conf.t Assisted-by: Claude Sonnet 5 (Anthropic) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org