[Bug 4945] New: Patron search is limited by default to the currently logged-in library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Summary: Patron search is limited by default to the currently logged-in library Change sponsored?: --- Product: Koha Version: HEAD Platform: All URL: /cgi-bin/koha/members/members-home.pl OS/Version: All Status: NEW Severity: major Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 The patron search form includes an option to limit by library which is hidden by default, and by default it selects the library at which the current user is logged in. This behavior is undesirable because there is no visual indication that the search is being limited. If the form field his hidden by default, it should also default to "Any." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com --- Comment #1 from Jane Wagner <jwagner@ptfs.com> --- If Independent Branches are on, then it should limit by library. Otherwise, I think you should get the choice. Maybe in the search line, add another pulldown for library? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- There is another pulldown for library. It's hidden by default along with the patron category option. You can display them by clicking the [+]. The library selector should default the current library only if IndependantBranches is on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I'd really like to see this bug get fixed before the release of 3.2. As it is this patron search is going to appear to be completely inaccurate to my librarians, who deal with patrons from many different libraries. I think the logic should work this way: - if the form has been submitted with a "branch" value, preselect that branch in branchloop. - if IndependantBranches is on, preselect the logged in user's branch in branchloop. - in ALL OTHER CASES the preselected branch should be "Any." It simply doesn't make sense to have the default case be a search limited to the logged-in user's branch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-08-20 15:50:29 UTC --- Created attachment 2558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2558 Proposed fix This is a high-priority bug for my library, so I took a stab at fixing this. Comments and corrections are welcome. I couldn't figure out how (or whether) GetBranchesLoop could be convinced to return a list of branches without selecting one, so I swapped GetBranchesLoop with GetBranches. This will preselect a branch only if a branch has been submitted as part of a query. This does NOT preselect the correct branch when IndependantBranches is turned on. I also added a template variable which is true if a query has been submitted with a branch or a category so that the extra form fields can be displayed, reminding the user that they added limiters to their query. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2010-09-24 13:56:16 UTC --- The expanded options should be set to display in any case where either branch or category code are not 'Any'. It may make more sense to create a new system preference to govern whether the currently logged in branch is pre-selected, rather than simply using IndependentBranches. This would give libraries the flexibility in their workflow to filter on their branch or not in patron search, independent of the other restrictions IndependentBranches implies. IndependentBranches should trump this system preference. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2010-12-27 13:09:17 UTC --- has anyone else taken a stab at this? It's a big deal for new libraries who migrate and one that is often reported as a bug until I point out the plus sign :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-01-04 14:06:34 UTC --- I have tested and signed off on this partial patch. It works as you described and it is an improvement over the way it worked before. Hopefully it will be accepted and someone else can solve the last missing piece. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-11 02:34:41 UTC --- Patch pushed, please test and hopefully create a follow up patch to finish off this bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #9 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-02 08:52:17 UTC --- This bug is mentioned in: Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library http://lists.koha-community.org/pipermail/koha-patches/2011-January/013499.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Pushed For QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-24 10:31:26 UTC --- Created attachment 3200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3200 Alternative patch with new preference Includes preference maxRecordsForFacets -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3200|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-02-24 10:32:48 UTC --- Comment on attachment 3200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3200 Alternative patch with new preference Oops, attached to wrong bug -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Sharon Moreland <smoreland@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |smoreland@nekls.org --- Comment #12 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-02 18:48:00 UTC --- This bug is mentioned in: Bug 3319 Followup: Fix compatibility with fix for bug 4945 http://lists.koha-community.org/pipermail/koha-patches/2011-February/013912.... --- Comment #13 from Sharon Moreland <smoreland@nekls.org> 2011-03-02 23:19:50 UTC --- Not sure where to report this, but I found a place where the [+] option is missing: cgi-bin/koha/members/member-flags.pl? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> 2011-03-03 17:32:03 UTC --- (In reply to comment #13)
Not sure where to report this, but I found a place where the [+] option is missing: cgi-bin/koha/members/member-flags.pl?
Display of the [+] option is dependent on the existence of the branch data: <!--TMPL_IF Name="branchloop"-->. The following templates share the same include which displays the search form: members\boraccount.tmpl members\deletemem.tmpl members\mancredit.tmpl members\maninvoice.tmpl members\member-flags.tmpl members\member-password.tmpl members\memberentrygen.tmpl members\messaging.tmpl members\moremember.tmpl members\notices.tmpl members\pay.tmpl members\readingrec.tmpl tools\import_borrowers.tmpl tools\picture-upload.tmpl All would display the [+] if the scripts were modified to pass "branchloop" data. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6253 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Pushed For QA |Needs Signoff --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-12 22:17:26 UTC --- This is still sitting awaiting a sign off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Patch Status|Needs Signoff |Does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Severity|major |normal --- Comment #16 from Liz Rea <wizzyrea@gmail.com> 2011-09-22 15:18:45 UTC --- changed back from does not apply to p5 normal, as we need the 2nd half. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org