[Bug 35944] New: Bookings is not taken into account in CanBookBeRenewed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Bug ID: 35944 Summary: Bookings is not taken into account in CanBookBeRenewed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 29002 I missed renewals booking checks in the original submission.. it needs adding to prevent renewals that would overlap with a future booking. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |35248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 [Bug 35248] Bookings needs unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162407&action=edit Bug 35944: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162408&action=edit Bug 35944: Add booking handling to CanBookBeRenewed This patch adds a bookings check to CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162407|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 162417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162417&action=edit Bug 35944: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162408|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 162418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162418&action=edit Bug 35944: Add booking handling to CanBookBeRenewed This patch adds a bookings check to CanBookBeRenewed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Note: With the patch applied, and a booking made so that the item can't be renewed - text displayed under '0 booked' says "(5 of 5 renewals remaining)". Testing notes (using KTD): 1. Make an item bookable: - Find a record with items - Go to the details page - Go to the items tab - For the item priority, change bookable to 'Yes' 2. Check out the item to a patron 3. Make a booking for another patron for a period that would be covered by the next renewal: - From the record page, select 'Place booking' - Select a patron - Select a period (starting date and ending date) - Submit 4. Renew the item - it is renewed, even though it is also booked during the period covered by the renewal 5. Cancel the booking and check in the item. 6. Apply the patch (including all the dependencies), updatedatabase, restart_all 7. Repeat steps 2 and 3 8. Should be unable to renew the item - should show 'booked' instead of the normal check box to select the item for renewal. 9. Tests should pass before and after the patch is applied: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162423&action=edit Bug 35944: Add message to SIP renewal attempt This patch adds a replacement for 'booked' to the SIP renewal handling so we can display 'Item is booked for another borrower'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162424&action=edit Bug 35944: Add link to 'booked' biblio in checkouts table This patch updates the checkouts table so handle 'booked' items including linking to the biblio booking details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just a couple of minor follow-ups to improve translatability in the checkouts table and properly handle things in SIP. Thanks for testing David :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 36040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- There is a whole dependency tree still in PQA for this one. Skipping for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162417|0 |1 is obsolete| | Attachment #162418|0 |1 is obsolete| | Attachment #162423|0 |1 is obsolete| | Attachment #162424|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163201&action=edit Bug 35944: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163202&action=edit Bug 35944: Add booking handling to CanBookBeRenewed This patch adds a bookings check to CanBookBeRenewed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163203&action=edit Bug 35944: Add message to SIP renewal attempt This patch adds a replacement for 'booked' to the SIP renewal handling so we can display 'Item is booked for another borrower'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163204&action=edit Bug 35944: Add link to 'booked' biblio in checkouts table This patch updates the checkouts table so handle 'booked' items including linking to the biblio booking details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163205&action=edit Bug 35944: (QA follow-up) Check if there are bookings before other calculations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163206&action=edit Bug 35944: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Very minor rebase, small follow-up to address performance concerns - could you just give a nod Martin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163201|0 |1 is obsolete| | Attachment #163202|0 |1 is obsolete| | Attachment #163203|0 |1 is obsolete| | Attachment #163204|0 |1 is obsolete| | Attachment #163205|0 |1 is obsolete| | Attachment #163206|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163208&action=edit Bug 35944: Unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163209&action=edit Bug 35944: Add booking handling to CanBookBeRenewed This patch adds a bookings check to CanBookBeRenewed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163210&action=edit Bug 35944: Add message to SIP renewal attempt This patch adds a replacement for 'booked' to the SIP renewal handling so we can display 'Item is booked for another borrower'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163211&action=edit Bug 35944: Add link to 'booked' biblio in checkouts table This patch updates the checkouts table so handle 'booked' items including linking to the biblio booking details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163212&action=edit Bug 35944: (QA follow-up) Check if there are bookings before other calculations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163213&action=edit Bug 35944: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Very happy with the follow-up, it gets my vote :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Waiting for Bug 35248 backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Bug 35944 depends on bug 35248, which changed state. Bug 35248 Summary: Bookings needs unit tests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.05 released in| | --- Comment #27 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #28 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org