[Bug 15569] New: Automatic renewal should not be displayed if the patron cannot checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Bug ID: 15569 Summary: Automatic renewal should not be displayed if the patron cannot checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 10860, 11577 If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 [Bug 10860] On-site checkouts (was In-House Use) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 [Bug 11577] Automatic renewals -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46594&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46594|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46613&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46613|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 46658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46658&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #4 from Marc Véron <veron@veron.ch> --- Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marc Véron from comment #4)
Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well?
At the bottom of the table, that's it (not auto renewal related)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 --- Comment #6 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #5)
(In reply to Marc Véron from comment #4)
Question: When renewals are not possible, should the form field "Renewal due date: ..." be removed as well?
At the bottom of the table, that's it (not auto renewal related)?
Yes, at the bottom of the table. It was just a question - I think this should have it's own bug (if we decide to remove it). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46658|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46701&action=edit Bug 15569: Do not displayed "automatic renewal" if the patron cannot checkout If the patron cannot checkout (debarred) and on-site checkout is enabled, the "Automatic renewal" checkbox should not be displayed on the circulation screen. Test plan: Enable OnSiteCheckouts and OnSiteCheckoutsForce Debar a patron and go on the circulation page. Without this patch, the automatic renewal checkbox is displayed. With this patch applied, it's not. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org