[Bug 26549] New: Show value of global system preferences on subscription form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Bug ID: 26549 Summary: Show value of global system preferences on subscription form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com If "Number of issues to display to ...:" input fields in the subscription form are left empty, the global values from the *SerialIssueDisplayCount system preferences are used. It would be nice to display a hint about the pref value on the form to help decide if you want overwrite it or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134937&action=edit Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 26378 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134937|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 134940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134940&action=edit Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134940|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135110&action=edit Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135110|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138067&action=edit Bug 26549: Show value of global system preferences on subscription form This patch modifies the subscription entry form so that the values of two system preferences are displayed as a hint to the user: The "Number of issues to display to staff" field will show the value of the StaffSerialIssueDisplayCount preference, and the "Number of issues to display to the public" field will show OPACSerialIssueDisplayCount. If the user has permission the system preference names will link to the system preferences page. To test, apply the patch and log into the staff interface as a user with permission to edit system preferences. - Go to Serials -> New subscription. - The "Number of issues to display to staff" field should have a hint under it: "Default: XX (StaffSerialIssueDisplayCount system preference)" - The "Number of issues to display to the public" field should have a hint under it: "Default: XX (OPACSerialIssueDisplayCount system preference)" - Log out and log back in as a user who does not have permission to edit system preferences. Return to the form and confirm that the hints do not link to system preferences. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Rebased and tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26549 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org