http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 5111 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This came up in an IRC discussion at one point, and it was pointed out that you shouldn't be able to delete a vendor from which orders have been placed because that would mess up information in other places. If a vendor delete option is added it should have a method of checking to see if the vendor ID is in use anywhere else. ---- i agree with owen's comment on bug 5111 but that's the same deal with bibs and items - you can't delete them if they're used - but you can delete them -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com AssignedTo|henridamien@koha-fr.org |adrien.saurat@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #5 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-01-31 10:32:03 UTC --- Created attachment 7398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7398 proposed patch A "Delete" button now appears on the bookseller display page, but only if this vendor doesn't have any basket. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2012-02-09 14:23:00 UTC --- This looks like it's working well, but I think we need to add, at the very least, a JavaScript prompt asking the user to confirm the deletion. Even better would be to have that JS prompt backed up by a server-side prompt, but I realize we don't always stick to that standard. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7398|0 |1 is obsolete| | --- Comment #7 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-02-09 15:23:21 UTC --- Created attachment 7532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7532 proposed patch #2 Good remark, we are deleting vendors without history here (no valuable data can be lost) so I wasn't struck by the lack of confirmation but it's always important indeed. I added a JS control. The deletion link passes through this control so it's impossible to delete without the confirmation. If you think of something else and have an idea for a server-side check, let me know and I'll see what I can do. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2012-02-10 20:11:26 UTC --- This no longer applies. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7532|0 |1 is obsolete| | --- Comment #10 from Adrien SAURAT <adrien.saurat@biblibre.com> 2012-02-23 14:22:55 UTC --- Created attachment 7830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7830 proposed patch #3 Added a check for any subscription link. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-24 06:16:53 UTC --- Hi Adrien, sorry, your patch does not apply any longer - I think it's because of bug 7113. Could you fix your patch to use booksellerid and resubmit please? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8071|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8072&action=edit [SIGNED-OFF] Bug 4969: deletion of suppliers If a vendor/bookseller has no basket/subscription link, it can now be deleted (after a JS confirmation). Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Verified that I can only delete vendors without linked orders or subscriptions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Ian Walls <koha.sekjal@gmail.com> --- New template param safely added, as well as a conditional check for basketcount before deletion. Template <li> element has id. Marking as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |rel_3_8 --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patches for this bug do not apply to 3.6. If you want this included in 3.6.x, please rebase on 3.6.x and reset the version to rel_3_6. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still think it would be a nice enhancement. And a way to shorten your search result list for special libraries. I think we can leave the bug open, but obsolete the patch that will not go into 3.6.x now probably. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8072|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4969 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #21 from Liz Rea <liz@catalyst.net.nz> --- We still need a "hide inactive vendors" function. If vendors cannot be deleted because they have associated basket/order/invoices, then they need to be able to be hidden when they are no longer in use. Another option would be to allow deletion of vendors but only with a superlibrarian account and 4x levels of confirmation (i.e. confirm you want to delete all invoices for X vendor (show them). Now confirm you want to delete all orders for this vendor (show them). Now confirm you want to delete all baskets for this vendor (show them). (accept all three) Delete this vendor?) Would probably also need a warning that doing this will upset acquisitions history. All of that seems like a lot of work to simply achieve "my list of vendors is too long and I only use 4 of these 150 vendors I have in my system" so probably better to just do something useful with the inactive flag. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.