[Bug 41373] New: Report share with mana not working when language_loop is not true
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Bug ID: 41373 Summary: Report share with mana not working when language_loop is not true Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: elias.lorgnier@biblibre.com Reporter: elias.lorgnier@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: alex.arnaud@biblibre.com In the mana-share-report.inc file, there is a condition that is only activated if languages_loop is defined. Inide this condition, the op parameter "cud-share" is defined for the share with mana form. If language_loop is false or undefined, the request has no "op" parameter, and therefor don't work. Moving the input tag that defines the op parameter out of the condition fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #1 from elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> --- Created attachment 190149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190149&action=edit Bug 41373: Fixing share report to mana not working Test plan : - Ensure the language_loop option is undefined by not having traducted languages (default on ktd test instance) - Try to share a report to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Blocks| |40885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40885 [Bug 40885] [OMNIBUS] Mana improvements to reports and subscriptions sharing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190149|0 |1 is obsolete| | --- Comment #2 from elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> --- Created attachment 192100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192100&action=edit Bug 41373: Fixing share report to mana not working Test plan : - Ensure the language_loop option is undefined by not having translated languages (default on ktd test instance) - Try to share a report to mana -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192100|0 |1 is obsolete| | --- Comment #3 from elias.lorgnier@biblibre.com <elias.lorgnier@biblibre.com> --- Created attachment 192140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192140&action=edit Bug 41373: Fixing share report to mana not working Test plan : - Ensure the language_loop option is undefined by not having translated languages (default on ktd test instance) - Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana) - Add the bin/mana utility to your path - run `mana up` to launch mana and create a docker network koha will connect to (see how to use the mana utility here : https://gitlab.com/koha-community/koha-mana/-/tree/main/compose?ref_type=hea...) - run `ktd --mana --skip-validation up` to connect koha to mana (compatible with other options) - create a security token, that will automatically get validated because of the skip-validation option - Try to share a report to mana (you can check on the UI or the import from mana interface, as there is no visual feedback of if that worked) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192140|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 196128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196128&action=edit Bug 41373: Fix Mana report sharing when only one language is enabled Test plan : - Disable all but one language in system preference StaffInterfaceLanguages - Start a local instance of Mana - Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana) - Edit compose/base.yml and uncomment the line: ${PWD}/sql/mana-sample.sql:/docker-entrypoint-initdb.d/test-data.sql - Run `bin/mana --skip-email-validation up -- -d` to launch mana and create a docker network koha will connect to - Run `ktd --mana up -d` to connect koha to mana - In Koha staff interface, go to "Administration » Share content with Mana KB": - Set "Share content with Mana KB" to "Yes", click "Save" - Fill the form under "Configure Mana KB", click "Send to Mana KB" - Try to share a report to mana. Go to Mana UI to verify that the report was correctly shared Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- The test plan requires https://gitlab.com/koha-community/koha-mana/-/merge_requests/41 to be merged. Alternatively you can validate a token manually by executing the following SQL query in Mana: UPDATE librarian SET activationdate = NOW() WHERE id = '<token>' Patch is trivial so I signed it off to push it to the QA queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196128|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #6 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 196334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196334&action=edit Bug 41373: Fix Mana report sharing when only one language is enabled Test plan : - Disable all but one language in system preference StaffInterfaceLanguages - Start a local instance of Mana - Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana) - Edit compose/base.yml and uncomment the line: ${PWD}/sql/mana-sample.sql:/docker-entrypoint-initdb.d/test-data.sql - Run `bin/mana --skip-email-validation up -- -d` to launch mana and create a docker network koha will connect to - Run `ktd --mana up -d` to connect koha to mana - In Koha staff interface, go to "Administration » Share content with Mana KB": - Set "Share content with Mana KB" to "Yes", click "Save" - Fill the form under "Configure Mana KB", click "Send to Mana KB" - Try to share a report to mana. Go to Mana UI to verify that the report was correctly shared Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198942&action=edit Bug 41373: Fix Mana report sharing when only one language is enabled Test plan : - Disable all but one language in system preference StaffInterfaceLanguages - Start a local instance of Mana - Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana) - Edit compose/base.yml and uncomment the line: ${PWD}/sql/mana-sample.sql:/docker-entrypoint-initdb.d/test-data.sql - Run `bin/mana --skip-email-validation up -- -d` to launch mana and create a docker network koha will connect to - Run `ktd --mana up -d` to connect koha to mana - In Koha staff interface, go to "Administration » Share content with Mana KB": - Set "Share content with Mana KB" to "Yes", click "Save" - Fill the form under "Configure Mana KB", click "Send to Mana KB" - Try to share a report to mana. Go to Mana UI to verify that the report was correctly shared Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41373 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org