[Bug 20104] New: Update minimum version of Perl to 5.20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Bug ID: 20104 Summary: Update minimum version of Perl to 5.20 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The C4::Log::cronlogaction uses caller, which did not exist prior to 5.20. And since Xenial, Debian 8, and Debian 9 all have versions at least 5.20 (the current version of perl is 5.26), it makes sense to update the version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 71074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71074&action=edit Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71074|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 73806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73806&action=edit Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73806|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73829&action=edit Bug 20104: Update minimum version of Perl to 5.20 This patch not only updates the version check, but repurposes the perlversion parameter, so as to not have to retranslate templates again when the version number changes after this. The changes are very self-evident. Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will also require a change to the release notes (scripts) I think as the minimal requirements are part of the text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to M. Tompsett from comment #0)
The C4::Log::cronlogaction uses caller, which did not exist prior to 5.20.
That is false. You can find "caller" in RHEL 6.9 which is still using Perl 5.10. And I just used it in Perl 5.18. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- I just bumped into this change preventing me from working on Koha master on OpenSUSE 42.3, which was released 2017-07-26. It uses Perl 5.18.2, which has worked fine with Koha. Requiring 5.20 seems like an awfully big decision, which seems to have had no discussion in the community. I'm going to send out a listserv email to hear what others have to say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- As Mason pointed out to me on IRC, the perldoc site search results seems broken for older versions of Perl. As you can see, caller has been around a very long time: https://perldoc.perl.org/5.8.8/functions/caller.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73829 Bug 20104: Update minimum version of Perl to 5.20 Review of attachment 73829: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20104&attachment=73829) ----------------------------------------------------------------- ::: installer/install.pl @@ +93,4 @@
$template->param( 'checkmodule' => 1 ) ; # we start with the assumption that there are no problems and set this to 0 if there are
+ unless ( $] >= 5.020000 ) { # Bug 20104
Then change this back to 5.010000 -- clearly the perldoc site needs improvement. I was just trying to make sure the version of perl needed was accurately reflected. @@ +93,5 @@
$template->param( 'checkmodule' => 1 ) ; # we start with the assumption that there are no problems and set this to 0 if there are
+ unless ( $] >= 5.020000 ) { # Bug 20104 + $template->param( problems => 1, perlversion => '5.20', checkmodule => 0 );
And this to 5.10 ::: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt @@ +70,4 @@
<p>I encountered some problems.</p> <ul> [% IF ( perlversion ) %] + <li>Your Perl version is out of date. Please upgrade to a newer version of Perl (at least version [% perlversion %]).</li>
Because this refactor is worth keeping, I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20594 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20594 [Bug 20594] Revert Perl version to 5.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #9)
Because this refactor is worth keeping, I believe.
I have put the reversion of Perl version in bug 20594. Thank you for correcting me, David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Update minimum version of |Update minimum version of |Perl to 5.20 |Perl to 5.20 because of | |caller() Status|Pushed to Master |CLOSED --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Reverted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org