[Bug 22070] New: OpacBrowseResults has broken link back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Bug ID: 22070 Summary: OpacBrowseResults has broken link back to search results Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Under certain conditions the OPACBrowseResults (navigation between results in OPAC) feature will have a broken link "back to results". To test: - Search for a term with diacritics. You can cheat a little here and search for something like "bööks" with the sample data. (ö will also find o). It's important that it's at least to result pages. - Go to the last result of the first result page - Verify the URL "back to results" works and diacritic shows up nicely - Go to the last result of the first page again - Navigate "Next >>" - Check "Back to results" again - Verify the link is broken and the diacritics are mangled Link looks something like this: http://localhost:8080/cgi-bin/koha/opac-search.pl?offset=20&q=b%C3%83%C2%83%C3%82%C2%B6%C3%83%C2%83%C3%82%C2%B6ks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid for 18.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11515, 11944 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11515 [Bug 11515] Encoding problem with OpacBrowseResults https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115529&action=edit Bug 22070: Try to fix encoding and escaping issue on browse result Pretty sure this does not work but in my tests it seems to fix the problem. Note that if there are several pages, the next link won't appear if you are on the last result of the first page. I don't understand why this code is so complicated, couldn't we port what we have on the staff interface (browser.js)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20529 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could this be somehow related to the discussion on bug 20529? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The encoding issue is still present in 20.11 and master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The Next link is not always hidden on the last result of the page, but sometimes, this might be another bug. If you keep previous/next'ing you will eventually see the next link to jump to first result of the second page and the link back to results breaks. The patch doesn't fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't understand, Katrin. What you are describing does not seem related to this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, it is related. In my test plan, it asks you to click on next from the last result of the first page, but you noted:
Note that if there are several pages, the next link won't appear if you are on the last result of the first page.
And it's true... but then it's not. I managed to sometimes have that 'next' button and then when you click it, it causes the encoding issue on the 'back to results' link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I don't seem to be able to reproduce this bug in master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll have another go at making this reproducable in a simpler way: 1) Fresh ktd sample database, reset_all, even used a private window. 2) OPAC: search for: bööks 3) Open detail page of last result on the result list. 4) In the browser, click on "Previous" 5) Check the URL for "back to results" - it will show broken characters 6) Click on it - it's broken ... and the patch fixes this for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115529|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136550&action=edit Bug 22070: Try to fix encoding and escaping issue on browse result Pretty sure this does not work but in my tests it seems to fix the problem. Note that if there are several pages, the next link won't appear if you are on the last result of the first page. I don't understand why this code is so complicated, couldn't we port what we have on the staff interface (browser.js)? Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know the patch and commit message need some more work, but maybe the updated test plan in comment#9 and the SO will help to get some more eyes on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- I do reproduce. Searching for bööks. Browsing from result n°18 to n°19 then n°20 does not break encoding. Browsing from result n°20 to n°19 breaks encoding. Browsing from result n°19 to n°18 does not break encoding. o_O -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #12)
I do reproduce.
Searching for bööks.
Browsing from result n°18 to n°19 then n°20 does not break encoding. Browsing from result n°20 to n°19 breaks encoding. Browsing from result n°19 to n°18 does not break encoding.
o_O
Thx Frido, I have a feeling it could have to do with the "last record on a page" somehow? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #12)
I do reproduce.
Searching for bööks.
Browsing from result n°18 to n°19 then n°20 does not break encoding. Browsing from result n°20 to n°19 breaks encoding. Browsing from result n°19 to n°18 does not break encoding.
o_O
With or without the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #14)
(In reply to Fridolin Somers from comment #12)
I do reproduce.
Searching for bööks.
Browsing from result n°18 to n°19 then n°20 does not break encoding. Browsing from result n°20 to n°19 breaks encoding. Browsing from result n°19 to n°18 does not break encoding.
o_O
With or without the patch?
Without patch. Feels strange to remove URI escape, we should try with URI chars like & ? = -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is very weird code. Apart from the encoding, the paging seems to be buggy too. Can reproduce the issue Frido mentioned: Back to results (pos 9 with 5 results per page WHEN coming back from pos 10) /cgi-bin/koha/opac-search.pl?idx=kw&sort_by=relevance_dsc&q=b%C3%83%C2%B6%C3%83%C2%B6k => böök The previous and next links are good, but the Back to results becomes even more bad when paging back and forth.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Have to conclude that this is not ready for passing QA yet. Just removing the encoding/escaping does not look good. We meet the issue here too of the encoding of CGI::Session. If we store unicode stuff (in the URL) within param busc, how does it get stored and how should we retrieve? It feels like we should do conversion as early as we retrieve and as late as we store it again. And such that it survives pure ASCII, Latin and 'real' Unicode. - use URI::Escape qw( uri_escape_utf8 uri_unescape ); + use C4::Search; This does not look good either. Probably we need to move URI::Escape to the top. The whole logic for Back and Next in this feature looks buggy. But that is outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |oleonard@myacpl.org |com | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I won't have time to dedicate to this in the near future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila@collect |koha@collecto.ca |o.ca, | |patrick.robitaille@collecto | |.ca | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22070 --- Comment #20 from Koha collecto <koha@collecto.ca> --- Retested in 23.05. Accented characters create issues with the Next scroll button (become grayed out) at the end of the first page of results and breaking the Return to results button. This behavior is not present if we replace the accented characters with a regular character (é by e). The two buttons (Next and Return to results) work normally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org