https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41405 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41405 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20338, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38704, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25219 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Status|Needs Signoff |In Discussion --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Maybe this is actually invalid? The code that checks these in Koha::Patron::is_patron_inside_charge_limit uses: 3512 my $no_issues_charge = $patron_category->noissuescharge || C4::Context->preference('noissuescharge'); 3513 my $no_issues_charge_guarantees = 3514 $patron_category->noissueschargeguarantees || C4::Context->preference('NoIssuesChargeGuarantees'); 3515 my $no_issues_charge_guarantors_with_guarantees = $patron_category->noissueschargeguarantorswithguarantees 3516 || C4::Context->preference('NoIssuesChargeGuarantorsWithGuarantees'); 3517 So if they are 0 they don't matter? I don't think it is supposed to work this way though - based on 41404 and the way NoIssuesCharge seems to work a 'blank' is "There is no limit" and Zero should be "Any fines should block issues" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41405 --- Comment #3 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Hi Nick, I am following your plan from the description and I am seeing the same behaviour. In Administration->Patron categories->Edit, the wording for Checkout charge limit is "If set, this will override the global value set in the noissuescharge system preference." So I agree with you that there's a problem: for me "if set" means "if this box isn't blank". A "0.00" value should mean that if patrons have more than 0.00 in fines, they can't checkout. This is not currently the case. (The Koha Manual is down right now, so I can't check if there are any subtleties I am missing.) What I am seeing when testing is this: 1) I have patron A in category ST. For category ST I followed your steps up to 8. I have patron B in category PT. I did not amend PT. 2) Both have fines of 2.50. The noissuescharge sys pref is set to its KTD default of 5. 3) Both patrons can checkout - even though the ST category has Checkout charge limit set to 0. 4) If the ST category Checkout charge limit is set to 1, patron A cannot checkout. 5) If the ST category Checkout charge limit is not set to a unit (0.01, 1.5), the value is rounded to the nearest unit when saving (0.01 becomes 0; 1.5 becomes 2). Also: 6) If the noissuescharge sys pref is set to 0, patrons can still checkout. You have to set it to 0.00 for them not to be able to checkout. Do we amend the text in the patron category setting and the sys pref or can we correct the behaviour? -- You are receiving this mail because: You are watching all bug changes.