[Bug 25911] New: Chrome tries to save patron passwords
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25911 Bug ID: 25911 Summary: Chrome tries to save patron passwords Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you are like me, you might have your browser try to save passwords for sites. I like having the browser in my office save some of my passwords. Logging into Koha is one of them. However, the problem with this is, every time I save a form that has a password associated with it, it wants to remember this password. This includes patron records. This is an annoyance. Now, my testing has been only with Chrome on this particular issue, and my workaround addresses this to some degree. So, if there is a more all-encompassing issue to address or solution, feel free to chime in. I've been able to work around this annoyance by adding the following to jQuery: $('#pat_memberentrygen #password,#pat_memberentrygen #password2').attr('readonly','').attr('onfocus','$(this).removeAttr("readonly");'); This will make the password fields readonly, which Chrome will ignore. If you need to edit the field, when you click on it, it will take the readonly attribute away, and it can be edited. Left as is, when you save, it will, of course, try to save the password. But it will only do so if the password is edited. If you leave it untouched, it will not bug you. I can take this one step further, I add this line to add the readonly attributes before saving. Then it won't bug me to save the password at all: $('#pat_memberentrygen #validate').attr('onmouseover', '$("#pat_memberentrygen #password,#pat_memberentrygen #password2").attr("readonly","");'); NOTE: Our Save button has the ID of "validate" because I have some validation code added to the form. But you get the idea here. When you hover over the save button, it adds the readonly attribute, and is ignored by the browser. I don't know if this helps anyone, or gives anyone an idea how to keep patron forms from being a nuisance to staff that save credentials, but I thought I would throw it out here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25911 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 129676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129676&action=edit Bug 29511: Sort hash keys This code exists in authorities/authorities.pl and the hash keys are sorted I just do the same here To test: 1 - Find/create a record with 245a 245h populated 2 - Load/reload the record several times and note that fields c and b are ordered randomly 3 - Apply patch 4 - Reload and note c and b are ordered alphabetically 5 - Move subfield h before subfield c 6 - Save and reload 7 - Confirm that existing/filled fields retain order in the MARC record Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129676|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 129676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129676 Bug 29511: Sort hash keys Bug number typo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25911 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Wondering if this could be incorporated somehow into Koha so staff are not saving passwords of patron accounts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org