[Bug 9584] New: Remove problematic IE CSS Hacks in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584 Bug ID: 9584 Summary: Remove problematic IE CSS Hacks in staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au Currently, there are several CSS rules, which are hacks for IE versions 7 and older, in staff-global.css. Within these, the hidden overflow property for *HTML BODY is cutting off lengthy content in search results, managing labels, etc. This prevents users from seeing the full pages of results, and prevents them from paging over for more results. While we might not want to support older versions of IE, this is problematic behaviour, and it shouldn't be happening. I'm not sure of the origin of these hacks, but it looks like we should remove them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 15214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15214&action=edit Bug 9584 - Remove problematic IE CSS Hacks in staff client To test: Before applying patch... 1) Open up Internet Explorer 6 or a newer version of Internet Explorer and use the F12 Developer Tools to change the Document Mode to Quirks Mode 2) Conduct a search on the staff client that will generate a high number of hits. (e.g. "e" as an unlimited query, if you have a maximum of a few thousand records.) 3) Note that you can't access the page options at the bottom of the page and that your result list is cut off at the bottom, and thus inaccessible. Apply patch... 4) Refresh your browser (preferably using F5 or whatever other method you use to bypass the browser's cache), and re-run the search if necessary 5) Note that you are now able to see the full page of search results, plus the paging at the bottom As far as I can tell, there are no regressions, but feel free to search for them. Afaik, there are no doc1 or doc2 ids, and I can't see any problems with any elements with doc3 IDs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #0)
While we might not want to support older versions of IE, this is problematic behaviour, and it shouldn't be happening. I'm not sure of the origin of these hacks, but it looks like we should remove them.
Unfortunately removing these lines of CSS breaks the functionality of the fixed-footer language chooser when you have multiple languages enabled. git blame works well in this case for digging up original intentions. If we are to fix this (and I'm not convinced we should fix bugs which only affect IE7 and earlier) we'll need a solution that doesn't break the language chooser. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org