http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9136 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13653&action=edit Bug 9136: C4::Tags not Plack-compatible The three module-scoped variables $ext_dict, @fields, and $select_all were preventing tagging code from working under Plack. I fixed this by changing the latter two to compile-time constants, and declared the first with "our $ext_dict;" To test (under Plack): 1) Try to create a tag before the patch is applied. Note that you get a 500 error in the AJAX request. 2) Apply patch. 3) Repeat step (1), noticing that this time the tag is created and there is no error. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9136 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13653|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13957&action=edit Bug 9136: C4::Tags not Plack-compatible The three module-scoped variables $ext_dict, @fields, and $select_all were preventing tagging code from working under Plack. I fixed this by changing the latter two to compile-time constants, and declared the first with "our $ext_dict;" To test (under Plack): 1) Try to create a tag before the patch is applied. Note that you get a 500 error in the AJAX request. 2) Apply patch. 3) Repeat step (1), noticing that this time the tag is created and there is no error. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9136 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: The patch works under Plack and Apache. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9136 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.