[Bug 25545] New: Invoice page - Adjustments are not included in the Total + Adjustments + Shipment cost (Column Tax. inc.)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Bug ID: 25545 Summary: Invoice page - Adjustments are not included in the Total + Adjustments + Shipment cost (Column Tax. inc.) Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: marjorie.barry-vila@collecto.ca QA Contact: testopia@bugs.koha-community.org Created attachment 105107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105107&action=edit adjustments Hi, Tested on 19.05.04: - Add adjustemts in an invoice - Display all details of invoice - See in the column "Total tax inc." on row "Total+Adjustments+Shipment" that Total does not include amount of Adjustment. See the attached screeshot. Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Version|19.05 |master --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was able to confirm this issue on master. To test: - Add a basket with at least one order - Close it - Receive shipment - Receive the order - Finish receiving - Add an adjustment of any amount - Verify in the invoice details table: - Total tax exc. is showing including the adjustmnt - Total tax inc. is missing the adjustment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: click on 'show details' to see the column with the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |19166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 [Bug 19166] Add the ability to add adjustments to an invoice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How is this supposed to work? The adjustment contains the tax or not? It seems that we are only adding that value to the "total tax excluded" value so far. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 105381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105381&action=edit Bug 25545: Add adjustments to total tax included Adjustments are not affected by tax, they are meant as a way to alter invoice values after receiving (damaged items, refuneds, extra charges, etc) When adjustments were added the tax included column was missed To test: - Add a basket with at least one order - Close it - Receive shipment - Receive the order - Finish receiving - Add an adjustment of any amount - Verify in the invoice details table: - Total tax exc. is showing including the adjustmnt - Total tax inc. is missing the adjustment - Apply patch - Reload - Total tax exc. is showing including the adjustmnt - Total tax inc. is showing including the adjustment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Invoice page - Adjustments |Invoice page - Adjustments |are not included in the |are not included in the |Total + Adjustments + |Total + adjustments + |Shipment cost (Column Tax. |shipment cost (Column tax. |inc.) |inc.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105381|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105443&action=edit Bug 25545: Add adjustments to total tax included Adjustments are not affected by tax, they are meant as a way to alter invoice values after receiving (damaged items, refuneds, extra charges, etc) When adjustments were added the tax included column was missed To test: - Add a basket with at least one order - Close it - Receive shipment - Receive the order - Finish receiving - Add an adjustment of any amount - Verify in the invoice details table: - Total tax exc. is showing including the adjustmnt - Total tax inc. is missing the adjustment - Apply patch - Reload - Total tax exc. is showing including the adjustmnt - Total tax inc. is showing including the adjustment Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105444&action=edit Bug 25545: (follow-up) Fix capitalization Total + Adjustments + Shipment cost ($) changed to: Total + adjustments + shipment cost ($) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Not sure I agree with the capitalization change.. I'd say each 'piece' in the sum is it's own title.. as such should be treated as a noun and thus capitalized.. no? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105443|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105646&action=edit Bug 25545: Add adjustments to total tax included Adjustments are not affected by tax, they are meant as a way to alter invoice values after receiving (damaged items, refuneds, extra charges, etc) When adjustments were added the tax included column was missed To test: - Add a basket with at least one order - Close it - Receive shipment - Receive the order - Finish receiving - Add an adjustment of any amount - Verify in the invoice details table: - Total tax exc. is showing including the adjustmnt - Total tax inc. is missing the adjustment - Apply patch - Reload - Total tax exc. is showing including the adjustmnt - Total tax inc. is showing including the adjustment Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105444|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 105647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105647&action=edit Bug 25545: (follow-up) Fix capitalization Total + Adjustments + Shipment cost ($) changed to: Total + adjustments + shipment cost ($) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- No point in holding up QA.. I've SO'd on both, but leave the decision about capitalization I've raised to the RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- I think the follow-up is correct: "Total + adjustments + shipment cost" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.07 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.07 |19.11.07, 19.05.12 --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org