https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9164 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |chris@bigballofwax.co.nz, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Something like that, would you agree guys? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2)

Something like that, would you agree guys?

Sounds good. Second patch contains other stuff too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73402|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73425&action=edit Bug 20489: Remove warnings from the interface -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No test plan provided, use your knowledge and imagination to know if these patches are relevant and enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Attempted steps to go to urls which should trigger modified code in both logged in and logged out states. Failures and successes as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73400|0 |1 is obsolete| | Attachment #73425|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73528&action=edit Bug 20489: Prevent DB user login -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #11)

This tweak is the one I don't understand.

It was not related to this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73529|0 |1 is obsolete| | --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73544&action=edit Bug 20489: Remove warnings from the interface Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- die "A patron with cardnumber '42' already exists" ???

From the new script misc/devel/create_superlibrarian.pl

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73544|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 74151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74151&action=edit Bug 20489: Remove warnings from the interface Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #21)

Just another note on that script: We should really remove the default koha/koha. Force people to enter something.

I think that a blocker for this one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17218 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure yet if this is the cause, but I cannot log in the OPAC with my staff user right now, which is not even superlibrarian? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For other confused comments see bug 20632. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #30)

I am not sure about this one.

Won't it remove the possibility to fix a forgotten superlibrarian password? I know there is the script, but it's often hard to get IT run something for you, especially in smaller libraries.

What is sure is that it put too much work on dev side, see related bug reports. We discussed that several times and I understood there was a general agreement on removing this "feature". It's a long standing problem and we will need to re-educate the users/sysadmin to use other tools, like the script to create real user accounts. I think we will certainly have to provide more tools to replace this workaround.

Have updates been tested? I don't see that in comment#9.

Marcel and I did.

What happens with libraries that didn't add a superlibrarian user in the past (pre-onboarding)?

They will have to create a superlibrarian user.

...

In the release notes it would be good to refer to the Forgot password feature >(hopefully enabled) or the script create_superlibrarian

The reset password feature won't ever be used by all libraries. For example libraries using LDAP, Shibboleth or CAS won't ever use it.

I do not understand what it means.

Also, why is there no proper test plan or nice description on the commit messages? (looking at you, Jonathan, this time! ;) )

I told it on comment 8, the idea was to let testers think about what I forgot. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |It is longer possible to release notes| |use the database user | |(defined in koha-conf.xml) | |to login into Koha. | |You | |should first create a | |superlibrarian patron and | |use it for logging in. | |See | |the script | |misc/devel/create_superlibr | |arian.pl Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20877 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Bug 20489 depends on bug 20580, which changed state. Bug 20580 Summary: create_superlibrarian.pl should accept parameters https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20580 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 11590 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36019 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36019 [Bug 36019] Dead code in tags/review -- You are receiving this mail because: You are watching all bug changes.