[Bug 35262] New: Improve OPAC self registration confirmation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Bug ID: 35262 Summary: Improve OPAC self registration confirmation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The OPAC self registration confirmation page has its content displayed without any margin to the left, directly at the outer line of the content box. This doesn't look very nice and could be improved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I don't think I can reproduce this problem. Can you attach a screenshot? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158542&action=edit Slef registration confirmation page Tested without email verification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Can confirm that I get the same results using Firefox (Developer Edition) and Chromium on Ubuntu 22.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158553&action=edit Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158553|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 158558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158558&action=edit Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158558|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158560&action=edit Bug 35262: Improve OPAC self registration confirmation page This patch corrects logic in the OPAC self registration confirmation template so that the right column markup is shown when various combinations of OpacNav, OpacNavBottom, and OpacNavRight are displayed. To test, apply the patch and enable the PatronSelfRegistration system preference, and deactivate the PatronSelfRegistrationVerifyByEmail preference. - Go to the OPAC and start the process of registering online. - Fill in the form and submit it. - On the registration confirmation page, check that the layout looks correct. - Test with the presence of various combinations of OpacNav, OpacNavBottom, and OpacNavRight HTML customizations. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small enhancement, I choose to backport Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35262 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org