[Bug 20875] New: OpacAddMastheadLibraryPulldown displays an empty list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Bug ID: 20875 Summary: OpacAddMastheadLibraryPulldown displays an empty list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 16735 Regression from commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735 [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20838 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75773&action=edit Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 [Bug 20838] Search by group of libraries is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75773|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 75790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75790&action=edit Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Signed Off --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Martin for catching the forgotten status change! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75790|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 75867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75867&action=edit Bug 20875: (bug 16735 follow-up) Fix library list for OpacAddMastheadLibraryPulldown This patch fixes a regression introduced by commit 2059f7d8016ab61172830e9b670279d3e28882b7 Bug 16735: Migrate library search groups into the new hierarchical groups It re-added code that was removed by bug 15758 (use of var BranchesLoop). Test plan: - Create library search groups - Turn OpacAddMastheadLibraryPulldown on - At the OPAC confirm that the search box with libraries and library groups is displayed and works correctly. - Remove the library search group - The dropdown list should not have the optgroup tags Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple change works as expected and doesn't break any tests. I'd love to see an accompanying selenium (or whatever) integration test, but as we don't yet have a clear framework for such tests I can't justifiably fail it for not having one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Keywords|rel_18_05_candidate | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 16735 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Bug 20875 depends on bug 20838, which changed state. Bug 20838 Summary: Search by group of libraries is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org