[Bug 7952] New: PDF::Reuse under plack writes to console STDOUT instead to browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Priority: P5 - low Change sponsored?: --- Bug ID: 7952 Assignee: cnighswonger@foundations.edu Summary: PDF::Reuse under plack writes to console STDOUT instead to browser QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: dpavlin@rot13.org Hardware: All Status: NEW Version: rel_3_6 Component: Label printing Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9161&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. Test secenario: 1. Home › Tools › Patron Card Creator › Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |7172 Assignee|cnighswonger@foundations.ed |dpavlin@rot13.org |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * there is an unconditional warn added: + warn "## Name [$opts{Name}] $fh"; please remove it of write $ENV{DEBUG} and warn "## Name [$opts{Name}] $fh"; -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9161|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9893&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. DEBUG=1 it will debugging output Test secenario: 1. Home › Tools › Patron Card Creator › Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9893|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10042&action=edit [Signed-off] Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. DEBUG=1 it will debugging output Test secenario: 1. Home › Tools › Patron Card Creator › Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * sorry about that, but there's an unconditionnal warn: + warn "## Name [$opts{Name}] $fh"; so, failed QA until you've removed it (or $ENV{DEBUG} &&...) Other than this, tiny patch, will pass QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10042|0 |1 is obsolete| | --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10090&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. Test secenario: 1. Home › Tools › Patron Card Creator › Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Sorry about that. It seems that I wanted to add $ENV{DEBUG} around that warn (and even included it in commit message) but never changed code. On second look, I think it's not really useful to anyone expect me while development so it's removed -- less cruft, more kittens! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10090|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10126&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. Test secenario: 1. Home › Tools › Patron Card Creator › Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: this time it's OK, nothing to object ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_6 |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed (I haven't tested it, I have no patron cards on y test database) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- This now needs a follow up to correct the behaviour in t/Creators.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10126|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 10278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10278&action=edit Bug 7952 - followup to fix t/Creators.t Since we are now using temporary file, we are creating test.pdf at end of test and checking if it exists and have non-zero size. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Trivial follow-up, make test working, will signoff/pass QA/push in one go -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed both the original and follow up to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org