[Bug 30884] New: Data loss when using batch patrons modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Bug ID: 30884 Summary: Data loss when using batch patrons modification Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Tools Assignee: slavashishkin@gmail.com Reporter: slavashishkin@gmail.com QA Contact: testopia@bugs.koha-community.org CC: nugged@gmail.com When using the batch patrons modification tool with an existing patron number we still get "No patron card numbers or borrowernumbers given." warning. To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the inspector tool see that cardnumberlist or borrowernumberlist is empty with no data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Data loss when using batch |incomplete replace of |patrons modification |jQueryUI tabs in | |modborrowers.tt breaks form | |sending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|incomplete replace of |Incomplete replace of |jQueryUI tabs in |jQueryUI tabs in |modborrowers.tt breaks form |modborrowers.tt breaks form |sending |sending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #1 from Andrew Nugged <nugged@gmail.com> --- Incompleteness came from these changes I suppose: commit:0f7949de Bug 30475: Convert tools pages tabs to Bootstrap (part 2) so yes, please finalize those changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29226 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incomplete replace of |Incomplete replace of |jQueryUI tabs in |jQuery UI tabs in |modborrowers.tt breaks form |modborrowers.tt breaks the |sending |form sending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 135682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135682&action=edit Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135682|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 135694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135694&action=edit Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incomplete replace of |Incomplete replace of |jQuery UI tabs in |jQuery UI tabs in batch |modborrowers.tt breaks the |patron modificatoin breaks |form sending |the form sending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incomplete replace of |Incomplete replace of |jQuery UI tabs in batch |jQuery UI tabs in batch |patron modificatoin breaks |patron modification breaks |the form sending |the form sending -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135694|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135726&action=edit Bug 30884: Fix jQuery selector to correctly detect active tab To reproduce: 1. Go to /tools/modborrowers.pl and fill form Card number list with data and click Continue. 2. It should give "No patron card numbers or borrowernumbers given." warning. 3. Using the browser inspector tool see that post fields cardnumberlist or borrowernumberlist is sent with empty data. Apply the patch, and then: 1. Fill form Card number or Borrowernumber list and click Continue. 2. Get the result: table with patrons for editing or warning about not found number. 3. Using the inspector tool see that request has data from the active tab in the form. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch, Slava! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #6 from Slava Shishkin <slavashishkin@gmail.com> --- Glad to hear it, Katrin. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx, pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It looks like missing dependencies for 21.05.x, it doesn't seem affected, no backport. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30475 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30475 [Bug 30475] Convert tools pages tabs to Bootstrap (part 2) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This one was actually reverted on 21.11.10, I didn't reproduced the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30884 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.01, |22.11.00, 22.05.01 released in|21.11.07 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org