[Bug 29671] New: Dropbox mode is unchecked after check in confirm on item with Materials specified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Bug ID: 29671 Summary: Dropbox mode is unchecked after check in confirm on item with Materials specified Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: christophe.torin@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org Created attachment 128374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128374&action=edit Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie-luce.laflamme@inlibro | |.com --- Comment #1 from Marie-Luce Laflamme <marie-luce.laflamme@inlibro.com> --- Both Koha versions 21.05 and 22.05 have this behaviour. I would be a huge improvement if the drop box mode could stay in memory after the checkin of an item with «material specified» (952$3). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 --- Comment #2 from geraud.frappier@inlibro.com --- Created attachment 140964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140964&action=edit Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 geraud.frappier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |geraud.frappier@inlibro.com Attachment #128374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 31620 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140964|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140974&action=edit Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|oleonard@myacpl.org |geraud.frappier@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 geraud.frappier@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140974|0 |1 is obsolete| | --- Comment #5 from geraud.frappier@inlibro.com --- Created attachment 140986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140986&action=edit Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Géraud <geraud.frappier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140986|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141110&action=edit Bug 29671: Dropbox mode is unchecked after check in confirm on item with Materials specified Suggested patch steps to reproduce : 1) Enable System preference CirConfirmItemParts 2) Go to Circulation > Check in 3) Enable Dropbox mode (Book drop mode) in the Checkin settings 4) Enter a barcode of an item having the 'Materials specified' field not empty 5) A Popup is shown, click the confirm button 6) The Dropbox mode (Book drop mode) is now unchecked, but should stay checked. In the template, the modal window lacks the dropboxmode input, so that it stays on the next page. I attached a patch with my suggested correction. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Géraud <geraud.frappier@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in| |21.11.15 Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15 |21.11.15, 21.05.22 Status|Pushed to oldstable |Pushed to oldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.08, |22.11.00, 22.05.08, released in|21.11.15, 21.05.22 |21.11.15 --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Not released in 21.05.22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29671 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- (In reply to wainuiwitikapark from comment #10)
Not released in 21.05.22
Reverted from 21.05 branch -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org