https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #2 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 114213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114213&action=edit Bug 23207: Add automatic_checkin column to itemtypes table installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 114215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114215&action=edit Bug 23207: Add automatic checkin feature This patch adds the posibility to set an itemtype with automatic checkin. It means that when the checkout is due, it will automatically check in. To test: 1. apply patches 2. updatedatabase 3. go to koha administration -> item types and edin an item type (from now on called itemtype1) CHECK => there is a checkbox almost at the end called automatic checkin 4. check that checkbox and save 5. checkout 2 items from itemtype1 and one item from another itemtype (from now on called itemtype2) 6. go to mysql database console (koha-mysql) and manually set date_due = current_timestamp in issues table for the item of itemtype2 and only one of the items of itemtype1 7. run cronjob at misc/cronjobs/automatic_checkin.pl 8. go to mysql database console again and select * from issues SUCCESS => All issues are present except for the issue of itemtype1 which had it's date_due set to current_timestamp. That one was automatically checked in. 9. prove t/db_dependent/Koha/Checkouts.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This sounds like a really interesting feature to handle our ILL copies. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117971&action=edit Bug 23207: Add automatic_checkin column to itemtypes table installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 117973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117973&action=edit Bug 23207: Add automatic checkin feature This patch adds the posibility to set an itemtype with automatic checkin. It means that when the checkout is due, it will automatically check in. To test: 1. apply patches 2. updatedatabase 3. go to koha administration -> item types and edin an item type (from now on called itemtype1) CHECK => there is a checkbox almost at the end called automatic checkin 4. check that checkbox and save 5. checkout 2 items from itemtype1 and one item from another itemtype (from now on called itemtype2) 6. go to mysql database console (koha-mysql) and manually set date_due = current_timestamp in issues table for the item of itemtype2 and only one of the items of itemtype1 7. run cronjob at misc/cronjobs/automatic_checkin.pl 8. go to mysql database console again and select * from issues SUCCESS => All issues are present except for the issue of itemtype1 which had it's date_due set to current_timestamp. That one was automatically checked in. 9. prove t/db_dependent/Koha/Checkouts.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117970|0 |1 is obsolete| | --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117984&action=edit Bug 23207: Add test Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117972|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117986&action=edit Bug 23207: Set automatic_checkin column as boolean in Itemtype schema Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Two tiny bits of feedback. On the item type setup page, I'd like to see the checkbox for automatic checkin moved up just underneath the checkbox for Not for Loan. That groups things a bit more thematically. Additionally, the text there currently reads: "If checked, items will be checked in automatically after a period of time. Useful for materials where you really don't care for fisical return, like museum passes, etc." I would suggest: "If checked, items will be automatically checked in once they've reached their due date." This clarifies how the checkin time is specified. I don't think we need a note here suggesting possible usage, that could go in the release notes and manual. If we want to retain that note, however, I 'd reword it as "This is useful for materials that do not require a physical checkin, such as museum passes, etc." -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117985|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117992&action=edit Bug 23207: Add automatic_checkin column to itemtypes table installer/data/mysql/kohastructure.sql Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Hasina Akhter <HasinaA@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117987|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 117994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117994&action=edit Bug 23207: Add automatic checkin feature This patch adds the posibility to set an itemtype with automatic checkin. It means that when the checkout is due, it will automatically check in. To test: 1. apply patches 2. updatedatabase 3. go to koha administration -> item types and edin an item type (from now on called itemtype1) CHECK => there is a checkbox almost at the end called automatic checkin 4. check that checkbox and save 5. checkout 2 items from itemtype1 and one item from another itemtype (from now on called itemtype2) 6. go to mysql database console (koha-mysql) and manually set date_due = current_timestamp in issues table for the item of itemtype2 and only one of the items of itemtype1 7. run cronjob at misc/cronjobs/automatic_checkin.pl 8. go to mysql database console again and select * from issues SUCCESS => All issues are present except for the issue of itemtype1 which had it's date_due set to current_timestamp. That one was automatically checked in. 9. prove t/db_dependent/Koha/Checkouts.t Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Hasina Akhter <HasinaA@pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117992|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119727&action=edit Bug 23207: Add automatic_checkin column to itemtypes table installer/data/mysql/kohastructure.sql Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Hasina Akhter <HasinaA@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117994|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119729&action=edit Bug 23207: Add automatic checkin feature This patch adds the posibility to set an itemtype with automatic checkin. It means that when the checkout is due, it will automatically check in. To test: 1. apply patches 2. updatedatabase 3. go to koha administration -> item types and edin an item type (from now on called itemtype1) CHECK => there is a checkbox almost at the end called automatic checkin 4. check that checkbox and save 5. checkout 2 items from itemtype1 and one item from another itemtype (from now on called itemtype2) 6. go to mysql database console (koha-mysql) and manually set date_due = current_timestamp in issues table for the item of itemtype2 and only one of the items of itemtype1 7. run cronjob at misc/cronjobs/automatic_checkin.pl 8. go to mysql database console again and select * from issues SUCCESS => All issues are present except for the issue of itemtype1 which had it's date_due set to current_timestamp. That one was automatically checked in. 9. prove t/db_dependent/Koha/Checkouts.t Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Hasina Akhter <HasinaA@pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Interesting feature.. works as described and contains tests and passes QA scripts. Passing QA I can see lots of use cases for this, it'll be interesting to see how it plays out.. Electronic resources, Inter-library loans etc.. I liked Andrews suggestions, so I went ahead an implemented them as a QA follow-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds a new release notes| |configuration option to the | |itemtype administration | |page: Automatic checkin. | |With automatic checkin | |enabled the item will be | |automatically checked in at | |its due date. | |In order for | |this feature to work | |correctly, the | |automatic_checkin.pl | |cronjob needs to be set up | |on your installation. Keywords| |Manual, | |release-notes-needed --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Happy to see this in PQA, trying to provide the release notes note. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Entry missing in misc/cronjobs/crontab.example 2. Any good reasons to not add the info in a new column of the itemtypes table? 3. (just grumbling) we really need to remove the item type at biblio level (item-level_itypes syspref) and have a FK on items.itemtype. Not having the ability to join here is terrible, we have to loop over all the checkouts... Not considering blocker but we may want to improve perf here in the future using the usual (ugly) condition for the join. 4. Thinking about the edge cases, date handling: don't we want to pass the due date for the return date, in order to not flag the checkin as overdue in the checkout history list? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #28)

(In reply to Jonathan Druart from comment #27)

...

1. Entry missing in misc/cronjobs/crontab.example

Good catch.

...

2. Any good reasons to not add the info in a new column of the itemtypes table?

You mean is missing the COMMENT?

Not sure if it#s there already, but I think waht's meant was administration > itemtypes - showing the setting there in column, so you can filter etc.

...

3. (just grumbling) we really need to remove the item type at biblio level (item-level_itypes syspref) and have a FK on items.itemtype. Not having the ability to join here is terrible, we have to loop over all the checkouts... Not considering blocker but we may want to improve perf here in the future using the usual (ugly) condition for the join.

This is a broader discussion, but biblio-level itype is really a thing, because it is used for filtering and facets as well.

I agree, we cannot remove the itemtype on biblio-level, it's tied to varioud features and checks (max reserves check for biblio level holds, article requests without items etc.) We could maybe remove it from MARC/only add it for indexing maybe? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28190 Status|Failed QA |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28190 [Bug 28190] Library limitation column not toggable on itemtypes table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 119967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119967&action=edit Bug 23207: (QA follow-up) Add new column on item types UI table Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27)

4. Thinking about the edge cases, date handling: don't we want to pass the due date for the return date, in order to not flag the checkin as overdue in the checkout history list?

No answer provided. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 119999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119999&action=edit Bug 23207: Regression tests This patch introduces a regression test for the case the automatic checkin happens after the date due. In that case the item souldn't really be overdue, and the checkin should be recorded with the date due as return date. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts.t => FAIL: The feature doesn't behave correctly Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- One last thing, shouldn't we display the "auto checkin" info in the checkout list (current checkouts at circulation.pl and circulation history)? Pushing as it, feel free to follow-up here or open a separate bug report if you think it is a good one to have for 21.05. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #41 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28913 [Bug 28913] Automatic checkin setting in item type setup should note required cronjob -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33887 [Bug 33887] Automatic checkin should be able to optionally fill the next hold with the returned item -- You are receiving this mail because: You are watching all bug changes.