[Bug 38689] New: EDIfact errors should log to a staff accessible location
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Bug ID: 38689 Summary: EDIfact errors should log to a staff accessible location Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 38423 We currently log a lot of detail using the editrace log, but it all goes onto server side only files. We should do similar to what we do for email delivery failures and log to a table and display user friendly errors in the UI so that end users are a) aware of such issues and b) may be able to resolve such issue's by updating their config and/or mappings. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38423 [Bug 38423] EDIFACT invoice files should skip orders that cannot be receipted rather than failing to complete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175788&action=edit Bug 38689: Add edifact_errors table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175789&action=edit Bug 38689: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175790&action=edit Bug 38689: Record errors on invoice processing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175789|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175793&action=edit Bug 38689: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175790|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175794&action=edit Bug 38689: Record errors on invoice processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175795&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175796&action=edit Bug 38689: Add basic rendering for errors in edifact messages display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com, | |kyle@bywatersolutions.com, | |nick@bywatersolutions.com, | |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This is an initial proof of concept.. we add a new table to store edifact processing errors and then we expose those on the API and finally in the edifact messages page for display. Currently, I've only dealt with basic processing errors that appear for invoices as a proof of concept and we could also do with working on the display of errors which is currently a tooltip on hover for the new 'with errors' that appears in the status column. I'm not really looking for a signoff here yet.. more looking for input on the approach -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175797&action=edit Current state of display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|EDIfact errors should log |EDIFACT errors should log |to a staff accessible |to a staff accessible |location |location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175809&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175809|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175810&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175797|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175811&action=edit Updated display using Modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175788|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175812&action=edit Bug 38689: Add edifact_errors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175793|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175813&action=edit Bug 38689: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175794|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175814&action=edit Bug 38689: Record errors on invoice processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175795|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175815&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175810|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175816&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Test plan The simplest way to test this is to comment the database rollback line in the EDI.t unit test and run the unit test to generate some errors and leave them in the database. Then you can view them by enabling the Edifact system preference and navigating to Acquisitions > EDI Messages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #19 from Ray Delahunty <r.delahunty@arts.ac.uk> --- (In reply to Martin Renvoize (ashimema) from comment #8)
I'm not really looking for a signoff here yet.. more looking for input on the approach Making problems easily visible would be good. We have a report on our Acquisitions homepage that tries to find problems with EDI but if staff don't run the report, nothing gets done. This bug triggered me running that report and I've seen a recent QUOTE message that errored, and the titles in it are not in our database, suggesting the report isn't routinely being run. (Maybe I should have used the Patron Emailer or runreport.pl in some way to routinely get problems made visible!).
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175817&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175812|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176127&action=edit Bug 38689: Add edifact_errors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175813|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176128&action=edit Bug 38689: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175814|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176129&action=edit Bug 38689: Record errors on invoice processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175815|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176130&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175816|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176131&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175817|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176132&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176133&action=edit Bug 38689: Record errors on quote processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176134&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38818 [Bug 38818] Add diag option to t::lib::Mocks::Logger -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176127|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176173&action=edit Bug 38689: Add edifact_errors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176128|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176174&action=edit Bug 38689: DBIC Schema Update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176129|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176175&action=edit Bug 38689: Record errors on invoice processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176130|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176176&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176131|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176177&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176132|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176178&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176133|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176179&action=edit Bug 38689: Record errors on quote processing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176134|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176180&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176181&action=edit Bug 38689: Improve logging of section We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #38 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176182&action=edit Bug 38689: Add section to output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #39 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176183&action=edit Display of errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Let me know what you think of the two output options.. one including the section of the edifact message that's throwing the error or the original without the message line split out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176173|0 |1 is obsolete| | Attachment #176174|0 |1 is obsolete| | Attachment #176175|0 |1 is obsolete| | Attachment #176176|0 |1 is obsolete| | Attachment #176177|0 |1 is obsolete| | Attachment #176178|0 |1 is obsolete| | Attachment #176179|0 |1 is obsolete| | Attachment #176180|0 |1 is obsolete| | Attachment #176181|0 |1 is obsolete| | Attachment #176182|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176373&action=edit Bug 38689: Add edifact_errors table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #42 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176374&action=edit Bug 38689: DBIC Schema Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #43 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176375&action=edit Bug 38689: Record errors on invoice processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #44 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176376&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #45 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176377&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #46 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176378&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #47 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176379&action=edit Bug 38689: Record errors on quote processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #48 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176380&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #49 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176381&action=edit Bug 38689: Improve logging of section We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #50 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 176382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176382&action=edit Bug 38689: Add section to output Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175811|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176373|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176524&action=edit Bug 38689: Add edifact_errors table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176374|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176525&action=edit Bug 38689: DBIC Schema Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176375|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176526&action=edit Bug 38689: Record errors on invoice processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> error message improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176376|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176527&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176377|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176528&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176378|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176529&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176379|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176530&action=edit Bug 38689: Record errors on quote processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176380|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176531&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176382|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176532&action=edit Bug 38689: Add section to output We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record and then display this alongside the error details. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #60 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176533&action=edit Bug 38689: Improve test coverage This patch drastically enhances the existing tests. We add tests for the various codepaths for handling EDI QUOTES including LIN segment splitting for multi-fund orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176524|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176605&action=edit Bug 38689: Add edifact_errors table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176525|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176606&action=edit Bug 38689: DBIC Schema Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176526|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176607&action=edit Bug 38689: Record errors on invoice processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> error message improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176527|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176608&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176528|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176609&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176529|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176610&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176530|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176611&action=edit Bug 38689: Record errors on quote processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176531|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176612&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176532|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176613&action=edit Bug 38689: Add section to output We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record and then display this alongside the error details. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176533|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 176614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176614&action=edit Bug 38689: Improve test coverage This patch drastically enhances the existing tests. We add tests for the various codepaths for handling EDI QUOTES including LIN segment splitting for multi-fund orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #71 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Fully covered by tests now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176605|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178359&action=edit Bug 38689: Add edifact_errors table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176606|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178360&action=edit Bug 38689: DBIC Schema Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176607|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178361&action=edit Bug 38689: Record errors on invoice processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> error message improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176608|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178362&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176609|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178363&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176610|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178364&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176611|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178365&action=edit Bug 38689: Record errors on quote processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176612|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178366&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176613|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178367&action=edit Bug 38689: Add section to output We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record and then display this alongside the error details. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176614|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178368&action=edit Bug 38689: Improve test coverage This patch drastically enhances the existing tests. We add tests for the various codepaths for handling EDI QUOTES including LIN segment splitting for multi-fund orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #82 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Just a rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This one is giving me some trouble on current main. Applying directly, I get the "sha1 information is lacking... could not build fake ancestor" error. When trying to to use the auto_rebase.pl with --bugzilla to create a branch pior of tidy, I get Resetting HEAD to where origin/main was at 2025-01-10T17:25:13Z (commit 8c3a42aa02752099963471d58d13cdfb391e0c3a) Applying patches using git bz Traceback (most recent call last): File "/usr/bin/git-bz", line 2839, in <module> applied = do_apply(bug_ref) ^^^^^^^^^^^^^^^^^ File "/usr/bin/git-bz", line 1860, in do_apply opt = prompt_multi("Follow? [(y)es, (n)o]", ["y", "n"]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/bin/git-bz", line 943, in prompt_multi line = input(f"{message} ") ^^^^^^^^^^^^^^^^^^^^ EOFError: EOF when reading a line I already have the dependent bug in main, will try again after I have pushed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I got past the dependency error, but it's still not applying: perl misc/devel/auto_rebase.pl --bugzilla 38689 Creating a temporary branch 'bug_38689-tmp'... Guessing a date to use from bugzilla's bug 38689 First patch from this bug was applied at 2025-01-10T17:25:13Z Resetting HEAD to where origin/main was at 2025-01-10T17:25:13Z (commit 8c3a42aa02752099963471d58d13cdfb391e0c3a) Applying patches using git bz error: sha1 information is lacking or useless (Koha/EDI.pm). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch Patch left in /tmp/Bug-38689-Improve-logging-of-section-xftgev49.patch Cannot apply the patches cleanly You can continue git-bz operation without this script. Once all the patches are applied retry without --bugzilla. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178359|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178492&action=edit Bug 38689: Add edifact_errors table Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178360|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178493&action=edit Bug 38689: DBIC Schema Update Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178361|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178494&action=edit Bug 38689: Record errors on invoice processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> error message improvement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178362|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178495&action=edit Bug 38689: Add Koha::Edifact::File::Error(s) classes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178363|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178496&action=edit Bug 38689: Display errors in a modal This patch adds a `(with errors)` link next to the status of any edifact messages that produced errors on processing. The link will popup a modal containing the error details recorded for that message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178364|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178497&action=edit Bug 38689: Update unit test We switch out the carp for a logger call in process_invoice, so we need ot update the unit test to compensate for that. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178365|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178498&action=edit Bug 38689: Record errors on quote processing Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178366|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178499&action=edit Bug 38689: Add logging tests for process_quote This adds missing tests for the Koha::Logger based logging of messages in the process_quote process. We also tidy up the log lines a tiny bit for consistency. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178367|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178500&action=edit Bug 38689: Add section to output We attempt to add the relevant part of the EDI message to the 'section' field of the edifact_errors record and then display this alongside the error details. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178368|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178501&action=edit Bug 38689: Improve test coverage This patch drastically enhances the existing tests. We add tests for the various codepaths for handling EDI QUOTES including LIN segment splitting for multi-fund orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, this makes t/db_dependent/TestBuilder.t fail, as does bug 30888. Putting a note here and there, can you please have a look? Maybe the same fix is needed: # Failed test 'Module Koha::Edifact::File::Errors should have koha_object[s]_class method if needed' # at t/db_dependent/TestBuilder.t line 500. # got: 'Can't locate object method "_new_from_dbic" via package "Koha::EdifactError" (perhaps you forgot to load "Koha::EdifactError"?) at /kohadevbox/koha/Koha/Object.pm line 385. # ' # expected: '' # Failed test 'Module Koha::EdifactError should be defined' # at t/db_dependent/TestBuilder.t line 506. # got: 'Can't locate Koha/EdifactError.pm in @INC (you may need to install the Koha::EdifactError module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.36 /usr/share/perl/5.36 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at (eval 3374) line 1. # ' # expected: '' # Failed test 'Module Koha::EdifactErrors should be defined' # at t/db_dependent/TestBuilder.t line 509. # got: 'Can't locate Koha/EdifactErrors.pm in @INC (you may need to install the Koha::EdifactErrors module) (@INC contains: /kohadevbox/koha /kohadevbox/koha/lib /kohadevbox/qa-test-tools /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.36.0 /usr/local/share/perl/5.36.0 /usr/lib/x86_64-linux-gnu/perl5/5.36 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.36 /usr/share/perl/5.36 /usr/local/lib/site_perl /var/lib/koha/kohadev/plugins) at (eval 3376) line 1. # ' # expected: '' # Looks like you failed 3 tests of 822. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #97 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178719&action=edit Bug 38689: (follow-up) Add koha_object(s)_class defintions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39215 [Bug 39215] EDIFACT quote files should skip orders that cannot be processed rather than failing to complete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39291 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39291 [Bug 39291] Edifact should record an error and move on if there's a problem with transport filename change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #98 from Jonathan Druart <jonathan.druart@gmail.com> --- Table wrongly placed in kohastructure it seems $ perl /kohadevbox/misc4dev/run_tests.pl --run-db-compare-only --compare-with=v24.05.00
-- Table structure for table `edifact_errors` --
DROP TABLE IF EXISTS `edifact_errors`; /*!40101 SET @saved_cs_client = @@character_set_client */; /*!40101 SET character_set_client = utf8mb4 */; CREATE TABLE `edifact_errors` ( `id` int(11) NOT NULL AUTO_INCREMENT, `message_id` int(11) NOT NULL, `date` date DEFAULT NULL, `section` mediumtext DEFAULT NULL, `details` mediumtext DEFAULT NULL, PRIMARY KEY (`id`), KEY `messageid` (`message_id`), CONSTRAINT `emfk_message` FOREIGN KEY (`message_id`) REFERENCES `edifact_messages` (`id`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; /*!40101 SET character_set_client = @saved_cs_client */;
-- 2887c2905 < /*!40101 SET character_set_client = utf8 */;
/*!40101 SET character_set_client = utf8mb4 */; 2910,2928d2927 < -- Table structure for table `edifact_errors` < -- < < DROP TABLE IF EXISTS `edifact_errors`; < /*!40101 SET @saved_cs_client = @@character_set_client */; < /*!40101 SET character_set_client = utf8 */; < CREATE TABLE `edifact_errors` ( < `id` int(11) NOT NULL AUTO_INCREMENT, < `message_id` int(11) NOT NULL, < `date` date DEFAULT NULL, < `section` mediumtext DEFAULT NULL, < `details` mediumtext DEFAULT NULL, < PRIMARY KEY (`id`), < KEY `messageid` (`message_id`), < CONSTRAINT `emfk_message` FOREIGN KEY (`message_id`) REFERENCES `edifact_messages` (`id`) ON DELETE CASCADE ON UPDATE CASCADE < ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; < /*!40101 SET character_set_client = @saved_cs_client */;
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #99 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181908&action=edit Bug 38689: Correctly place edifact_errors in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 --- Comment #100 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #99)
Created attachment 181908 [details] [review] Bug 38689: Correctly place edifact_errors in kohastructure.sql
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Summary:** release notes| |Previously, | |EDIFACT import errors were | |only visible in server | |logs, making | |troubleshooting difficult | |for staff. | | | |**Fix:** | |Errors are now logged in a | |location accessible via the | |staff interface, allowing | |easier review and | |follow-up. | | | |**Impact:** | |Helps acquisitions staff | |and sysadmins quickly | |identify and resolve issues | |with vendor data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Summary:** |**Summary:** release notes|Previously, |Previously, |EDIFACT import errors were |EDIFACT import errors were |only visible in server |only visible in server |logs, making |logs, making |troubleshooting difficult |troubleshooting difficult |for staff. |for staff. | | |**Fix:** |**Fix:** |Errors are now logged in a |Errors are now logged in a |location accessible via the |location accessible via the |staff interface, allowing |staff interface, allowing |easier review and |easier review and |follow-up. |follow-up. | | |**Impact:** |**Impact:** |Helps acquisitions staff |Helps acquisitions staff |and sysadmins quickly |and sysadmins quickly |identify and resolve issues |identify and resolve issues |with vendor data. |with vendor data. | | | |**Sponsored by** *Open | |Fifth* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #101 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Christine Lee <chlee@pascolibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chlee@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Bug 38689 depends on bug 38818, which changed state. Bug 38818 Summary: Add diag option to t::lib::Mocks::Logger https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38818 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40383 [Bug 40383] Modernise the EDIFACT Message display modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38689 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41996 [Bug 41996] Further improvements to EDIFACT error recording -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org