[Bug 19791] New: patron Modification log redirects to circulation page ( Koha 17.11)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Bug ID: 19791 Summary: patron Modification log redirects to circulation page (Koha 17.11) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ayousef@kwareict.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Dear all, - Showing patron Modification log from koha 17.11 doesn't show any system log for the patron, Instead it redirects to (http://domain_name/cgi-bin/koha/circ/circulation.pl?borrowernumber=) - Just try filling the (Librarian:) field with the borrower number instead of the (Object:) field, And leave the (Object:)field empty, You will see what I mean. - Also you can test it here (http://koha.adminkuhn.ch:8080/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=1&src=circ), It's a demo site for koha 17.11 provided by koha community here (https://koha-community.org/demo/) use (demo/demo) for logging in, Then test it for this user (Herr Demokrit Morgenstern (1)), Also the problem was not in koha 17.05, You can test it using Bywater demo version (koha17.05), You will see that it working fine in koha (17.05). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With bug 19080 we tried to redirect to the circulation home page when the borrowernumber did not exist (anymore). When you click on the "modification log" tab, the "object" parameter is automatically filled with the borrowernumber of the patron you are looking at. If you decide to empty this field or use a non-existent borrowernumber, you will get redirected to the circulation home page. I would suggest to: - Disable the "object" input and force the value to borrowernumber when we come from the circulation module and redirect to circ home page if non-existent - Make it editable when come from the tools module and display a "no logs" message if non-existent borrowernumber is used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19080 [Bug 19080] Handle non existing patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|patron Modification log |patron Modification log |redirects to circulation |redirects to circulation |page (Koha 17.11) |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 --- Comment #2 from Abdou Yousuf <ayousef@kwareict.com> --- (In reply to Jonathan Druart from comment #1)
With bug 19080 we tried to redirect to the circulation home page when the borrowernumber did not exist (anymore).
When you click on the "modification log" tab, the "object" parameter is automatically filled with the borrowernumber of the patron you are looking at.
If you decide to empty this field or use a non-existent borrowernumber, you will get redirected to the circulation home page.
I would suggest to: - Disable the "object" input and force the value to borrowernumber when we come from the circulation module and redirect to circ home page if non-existent - Make it editable when come from the tools module and display a "no logs" message if non-existent borrowernumber is used.
I don't think that it's beneficial to automatically fill (Object field) with the borrower number, On the contrary I think that the (Librarian:) field should be automatically filled by borrower number rather than (Object field), And it will be more beneficial, In fact I don't know why borrower number should be in (Object field) and not (Librarian field) when selecting "modification log" tab, What are the benefits? Also, You said that you tried to redirect to the circulation home page when the borrower number did not exist (anymore), How it can be? I think it's not logical even though it can be done programmatically. Regards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Abdou Yousuf from comment #2)
(In reply to Jonathan Druart from comment #1)
With bug 19080 we tried to redirect to the circulation home page when the borrowernumber did not exist (anymore).
When you click on the "modification log" tab, the "object" parameter is automatically filled with the borrowernumber of the patron you are looking at.
If you decide to empty this field or use a non-existent borrowernumber, you will get redirected to the circulation home page.
I would suggest to: - Disable the "object" input and force the value to borrowernumber when we come from the circulation module and redirect to circ home page if non-existent - Make it editable when come from the tools module and display a "no logs" message if non-existent borrowernumber is used.
I don't think that it's beneficial to automatically fill (Object field) with the borrower number, On the contrary I think that the (Librarian:) field should be automatically filled by borrower number rather than (Object field), And it will be more beneficial, In fact I don't know why borrower number should be in (Object field) and not (Librarian field) when selecting "modification log" tab, What are the benefits?
The tabs on patron pages are all relevant to current patron, that is the reason why borrowernumber is in object - you want here to get information about this patron.
Also, You said that you tried to redirect to the circulation home page when the borrower number did not exist (anymore), How it can be? I think it's not logical even though it can be done programmatically.
It could be possible - for example one librarian deletes a patron and the second librarian wants to show some information about patron.
Regards.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I would suggest to: - Disable the "object" input and force the value to borrowernumber when we come from the circulation module and redirect to circ home page if non-existent - Make it editable when come from the tools module and display a "no logs" message if non-existent borrowernumber is used.
That would work for me. Also agree with Josef that using the borrowernumber of the patron in object is the expected behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|patron Modification log |Patron Modification log |redirects to circulation |redirects to circulation |page |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21242 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98922&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98922|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98967&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98967|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99220&action=edit Bug 19791: Keep user in circ when viewing patron's logs When a librarian is viewing the log for a given patron (tab "modification log" from the circulation module), the "object" and "modules" parameter can be modified. It does not make sense, we should stay in the circulation module and avoid those fields to be modified. Test plan: - Modify several patrons (in order to have several modification logs) - Go to the modification log tab of one of them - Notice that the "Object" input is not a "Borrowernumber" labelled input and that you cannot modify it. Also notice that the "modules" is hidden. - Go to the log viewer tool and notice that the view is still the same as before this patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, no regressions found and QA scripts pass.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19791 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25249 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25249 [Bug 25249] When viewing a patron's modiification log we should see both the MEMBERS and CIRCULATION modules -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org