[Bug 10092] New: Small improvements on serial missinglist and receivedlist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Bug ID: 10092 Summary: Small improvements on serial missinglist and receivedlist Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Serials Assignee: m.de.rooy@rijksmuseum.nl Reporter: m.de.rooy@rijksmuseum.nl CC: colin.campbell@ptfs-europe.com Followup report for bug 8896 updating missinglist. Similar changes should be made to receivedlist (note that unfortunately this field is called recievedlist in the database). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- This patch also removes the "not issued "-string from the missing list. The issue is marked as not available and therefore missing. The status field is sufficient. The additional text was not cleared in the past when the missing status was changed to another status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Optionally, we could even add a db rev to get rid of all "not issued "-occurrences in all missinglist's. What do you think? I did not add it at this moment.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8896 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17576&action=edit Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17580&action=edit Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2012-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2012-09-24 00:00:00 |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha.aixmarseille@gmail.com --- Comment #5 from Koha Team AMU <koha.aixmarseille@gmail.com> --- This patch adds the "not available" or "missing" at the missing list. He adds the "received" at the received list. It works even when I change status. The missing list and the received list are OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17576|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21960&action=edit Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 21961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21961&action=edit Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * passes koha-qa.pl * works fine, except for the following glitch: let's suppose you've issue #100 missing, and #99 #101 recieved. When you change the #100 status because you get it, the receivedlist will be #99; #101; #100, which is not perfect. But it's better than previously, so passing QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21960|0 |1 is obsolete| | Attachment #21961|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22246&action=edit Bug 10092: Small improvements on serial missinglist and receivedlist Builds upon report 8896 with changes for missinglist. Similar changes for receivedlist to be consistent. Test plan: Go to serial collection information. Edit serials. Toggle the status through all possible values. On another tab or in the db, check missinglist and receivedlist (subscription detail tab Summary). Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 22247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22247&action=edit Bug 10092 Followup for NewIssue Same logic for new issue. Moves the shared code to a local subroutine. Test plan: Add an issue via Generate Next button. No changes to missing and received. Now add an issue via Edit Serials and Supplemental issue with status Arrived. Check the received list. Now add supplemental issue with status Missing or Not available. Check the missing list. Signed-off-by: Koha Team Amu <koha.aixmarseille@gmail.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- And yet another patch (from April 22 !!) down the drain.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marcel, What did you mark this bug report as won't fix? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- The question is "Why", not "What" :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
Marcel, What did you mark this bug report as won't fix?
Giving up on rebasing these patches.. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org