[Bug 18326] New: Add Mojolicious as a required dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 Bug ID: 18326 Summary: Add Mojolicious as a required dependency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org With the pushing of Bug 17932, we now have to add Mojolicious as a required module to Koha. Otherwise, bad things happen, since Koha::Object uses Mojo::JSON. I don't think this is necessarily a bad thing. Mojolicious is an easy install and maybe we could start using it more anyway. Hello new OPAC... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932 [Bug 17932] Koha::Object should provide a TO_JSON method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 61593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61593&action=edit Bug 18326 - Add Mojolicious as a required dependency Since Bug 17932 was pushed and adds Mojo::JSON to Koha::Object, it's necessary to specify Mojolicious as a required module. _TEST PLAN_ 1. Run: perl koha_perl_deps.pl -a -r -c 2. Make sure that Mojolicious is in the output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Maybe bug 18290 could provide an alternative solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #2)
Maybe bug 18290 could provide an alternative solution.
Sounds good to me. I've already installed Mojolicious so that I can continue to use Koha master, but an alternative solution seems reasonable! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18326 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this patch might be obsolete - it's already marked required on master: }, 'Mojolicious' => { 'usage' => 'REST API', 'required' => '1', 'min_ver' => '6.0', }, Not sure which status... choosing to close, please reopen if I am mistaken. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org