https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40251 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40251 [Bug 40251] Icon for self-check user permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thank you Frido! I was coming to bugzilla to file this. I noticed it in 26.05. When a patch is attached, it should be backported at least until the versions where Bug 40251 was released in if still applicable (25.11 and 25.05). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 211638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211638&action=edit Bug 42650: Don't show icon for self-check for a superlibrarian Bug 40251 added icon for self-check when user has the correct permission. They appear for a superlibrarian. Looks strange and in my opinion is useless. Test plan : 1) Create a user with only permissions self_checkout_module and self_checkin_module 2) Go to its page => You see icons of sco and sci 3) Create a user superlibrarian 4) Go to its page => You only see icons of staff and superlibrarian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- @QA I'm not sure if code is pretty, feel free to correct ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #211638|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 211640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211640&action=edit Bug 42650: Icon for self-check user permission should not appear for a superlibrarian This alternate patch uses template logic to hide the icons for staff, self-checkout, and self-checkin if the user is a superlibrarian. Test plan : 1) Create a user with only permissions 'self_checkout_module' and 'self_checkin_module' 2) Go to its page => You see only icons of sco and sci 3) Create a user with only permission 'catalogue' 4) Go to its page => You only see icon of staff (shield) 3) Create a user superlibrarian 4) Go to its page => You only see icon superlibrarian (bolt) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42650 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've added a test plan with 3 steps because its removed staff icon for a superlibrarian. In my opinion this makes sens, a superlibrarian is obviously a staff. Note that it does not impact class="patroninfo is-staff is-superlibrarian". Which is good. Signed \o/ -- You are receiving this mail because: You are watching all bug changes.