[Bug 18784] New: Add 'auto claim' option to subscription batch edit tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Bug ID: 18784 Summary: Add 'auto claim' option to subscription batch edit tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Depends on: 18426, 18783 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 [Bug 18426] Subscriptions batch editing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783 [Bug 18783] Allow automatic claims for serials -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 64196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64196&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- For test plan see bug 18426 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by depending patches in Failed QA :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Patch is missing a closing HTML tag </li> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Bug 18784 depends on bug 18426, which changed state. Bug 18426 Summary: Subscriptions batch editing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64196|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 91429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91429&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master + added the missing closing HTML tag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91429|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 124985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124985&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #9 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this on PTFS Europe's sandbox and got the following error when I changed in batch edit Enable automatic claims -> Yes. The method Koha::Subscription->auto_claim_enabled is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 931 Koha::Object::AUTOLOAD('Koha::Subscription=HASH(0x561f2228ef70)', 1) called at /kohadevbox/koha/serials/subscription-batchedit.pl line 75 eval {...} at /kohadevbox/koha/serials/subscription-batchedit.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::__ANON__('CGI::Compile=HASH(0x561f212bfe10)', '', '/kohadevbox/koha/serials/subscription-batchedit.pl', '/kohadevbox/koha/serials', 'ARRAY(0x561f215d3778)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::subscription_2dbatchedit_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x561f2188aa88)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)', '/kohadevbox/koha/serials/subscription-batchedit.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x561f212ef248)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x561f212f6f58)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f2161c7c8)', 'Try::Tiny::Catch=REF(0x561f21ff9598)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x561f212f69d0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x561f21515c98)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x561f200e95f8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x561f212f6da8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 106 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x561f21407f80)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x561f21515b78)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x561f21515ed8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x561f173e77f0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 38 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f21d32aa8)', 'Try::Tiny::Catch=REF(0x561f221c52c0)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x561f200de578)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x561f200dd7c8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x561f200dd708)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x561f16e053b0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x561f16e053b0)', 'Net::Server::Proto::UNIX=GLOB(0x561f21a137c8)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x561f16e053b0)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'port', 'ARRAY(0x561f17392100)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'bug18784-koha', 'group', 'bug18784-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'pid_file', '/var/run/koha/bug18784/plack.pid', 'setsid', 1, 'log_file', '/var/log/koha/bug18784/plack-error.log', 'background', 1) called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'CODE(0x561f16e05260)', 'HASH(0x561f16e05008)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x561f16e05278)', 'CODE(0x561f16e05260)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x561f16b56f10)', 'Plack::Handler::Starman=HASH(0x561f16e05278)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x561f16af0360)') called at /usr/bin/starman line 38 at /usr/share/perl5/Exception/Class/Base.pm line 88 I tried to refresh the schema and restart the services but there was no change. Any tips how to test this further? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155464&action=edit Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124985|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155465&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155464|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 155466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155466&action=edit Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added the missing DBIC files to the dependency bug added a follow-up here to get it passing the QA scripts. Be great to have some testing on this pair now the sandboxes should be available to test this one at least (for the dependency, you'll need to ask for some help to enable the new cronjob) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #14 from David Nind <david@davidnind.com> --- The patch no longer applies: git bz apply 18784 Bug 18784 - Add 'auto claim' option to subscription batch edit tool 155465 - Bug 18784: Add 'auto claim' option to subscription batch edit tool 155466 - Bug 18784: (QA follow-up) Tidy code block Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18784: Add 'auto claim' option to subscription batch edit tool Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt M serials/subscription-batchedit.pl Falling back to patching base and 3-way merge... Auto-merging serials/subscription-batchedit.pl CONFLICT (content): Merge conflict in serials/subscription-batchedit.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-batchedit.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 18784: Add 'auto claim' option to subscription batch edit tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155465|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 167333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167333&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155466|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 167334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167334&action=edit Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167333|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167355&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167334|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167356&action=edit Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167355|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168425&action=edit Bug 18784: Add 'auto claim' option to subscription batch edit tool Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167356|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168426&action=edit Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We moved again.. rebased and added my SO lines.. I'm happy to call this PQA.. but it appears the dependency hasn't been tested or signed off yet :! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Whilst this is technically PQA.. it's actually BLOCKED by it's dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org